all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 42482@debbugs.gnu.org, "Milan Stanojević" <mstanojevic@janestreet.com>
Subject: bug#42482: 27.0.91; emacs modules memory leak
Date: Sat, 1 Aug 2020 14:11:54 +0200	[thread overview]
Message-ID: <CAArVCkQkwj_NhDJaaN+H7pPHuMXv+QroTD4gdPQQKqMc=1UdYA@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkS6QCXZxxBkKQ-7dtHcfhZ1VLTp_tX5PNwTqq-5cxJ93A@mail.gmail.com>

Am Sa., 25. Juli 2020 um 23:43 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
> Am Do., 23. Juli 2020 um 19:45 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
> >
> > > From: Philipp Stephani <p.stephani2@gmail.com>
> > > Date: Thu, 23 Jul 2020 16:33:12 +0200
> > > Cc: 42482-done@debbugs.gnu.org
> > >
> > > Am Do., 23. Juli 2020 um 16:29 Uhr schrieb Milan Stanojević
> > > <mstanojevic@janestreet.com>:
> > > >
> > > > Thank you for the quick fix.
> > > > Is there a chance this also goes to emacs-27 branch so it can be in
> > > > the emacs 27.1 when it gets released?
> > >
> > > I think backporting the fix should be fine, as the fix is rather
> > > localized and fixes a regression. Eli?
> >
> > How well was it tested?  The change is not exactly trivial.  But if
> > you are satisfied with the testing enough to have this in emacs-27,
> > I'm okay with that.
>
> I'd like to have a few more test cases around global references in
> emacs-27, as the current test cases only test some simple/success
> cases, and we'd probably want to test at least a few more edge cases
> (e.g. freeing global references in a different order than allocating
> them). I've added two more test cases on master and will see that I
> can add a few more in the coming days.

I've now added a few more tests and backported the fix to the release branch.





  reply	other threads:[~2020-08-01 12:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 23:25 bug#42482: 27.0.91; emacs modules memory leak Milan Stanojević
2020-07-23 12:06 ` Philipp Stephani
2020-07-23 14:29   ` Milan Stanojević
2020-07-23 14:33     ` Philipp Stephani
2020-07-23 17:45       ` Eli Zaretskii
2020-07-23 19:11         ` Milan Stanojević
2020-07-25 21:43         ` Philipp Stephani
2020-08-01 12:11           ` Philipp Stephani [this message]
2020-08-01 12:37             ` Eli Zaretskii
2020-08-01 12:55               ` Nicolas Petton
2020-08-01 14:47                 ` Philipp Stephani
2020-08-02 17:25                 ` Eli Zaretskii
2020-08-03 23:02                   ` Milan Stanojević
2020-08-04  8:05                   ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkQkwj_NhDJaaN+H7pPHuMXv+QroTD4gdPQQKqMc=1UdYA@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=42482@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mstanojevic@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.