From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#40109: 27.0.90; simple-delete-trailing-whitespace--bug-21766 fails if Git isn't installed Date: Tue, 17 Mar 2020 18:35:33 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="125520"; mail-complaints-to="usenet@ciao.gmane.io" To: 40109@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 17 18:36:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEG8U-000WYY-EH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Mar 2020 18:36:14 +0100 Original-Received: from localhost ([::1]:37604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEG8T-0007BI-A9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Mar 2020 13:36:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44681) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEG8J-0007Aq-F5 for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2020 13:36:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEG8I-0008EI-9D for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2020 13:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33556) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEG8I-0008CT-3n for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2020 13:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jEG8I-0000cQ-13 for bug-gnu-emacs@gnu.org; Tue, 17 Mar 2020 13:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Mar 2020 17:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40109 X-GNU-PR-Package: emacs Original-Received: via spool by 40109-submit@debbugs.gnu.org id=B40109.15844665522361 (code B ref 40109); Tue, 17 Mar 2020 17:36:01 +0000 Original-Received: (at 40109) by debbugs.gnu.org; 17 Mar 2020 17:35:52 +0000 Original-Received: from localhost ([127.0.0.1]:39529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEG88-0000c1-8r for submit@debbugs.gnu.org; Tue, 17 Mar 2020 13:35:52 -0400 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:46781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEG86-0000bk-O8 for 40109@debbugs.gnu.org; Tue, 17 Mar 2020 13:35:51 -0400 Original-Received: by mail-ot1-f54.google.com with SMTP id 111so22481533oth.13 for <40109@debbugs.gnu.org>; Tue, 17 Mar 2020 10:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=VxsUkUsrrlD1F9rZcswclo/2+zOlAsAUL722m5+FKwA=; b=RhXOeqI47MMXRO+O6PnbpV6JG+/tll8qOMhVWhHF42P/7So+2uOE4AEDyE3SN24D3O 7oqPH0rzG7JX5L8rbXji0SEV08PQ0Oo1Vofh52O30RQDT0Nw3m1zGR4xjqplC1UXoBxU tUojkwbxPNE8PbEsUDDv4E01mK955oAN9azEX9ab291KGfJyeTRktrqL9vz6wgbtpGJf qV3yIvoq1B1x/mwS45nd2jyBXQWmvinLn3iR3Kius15SifdLzuG0eFERkFOsCCCdYulN 1cELisz9PJbQoiAayFvzOOjrayp8zVhDAACDqb3VWy0SPF9gIXr2ANpsuB5EgQDeNFAl 7yjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=VxsUkUsrrlD1F9rZcswclo/2+zOlAsAUL722m5+FKwA=; b=lsGSxj3DuuP4kNJ3zdOOBFWXh/crK1Y1eaBd79zXNEbzqHLCNbuVA0Mq8zyJudJzVZ KrgmMhPeNDQORYvkKdvIBXv0rIvPxc7rX5EegLLEJq/2erjLgil5/uAbypy65VfsZ6Px UlZJrfcGf7PPARZRm0+8yN6SJZ2/1DvyuuTp88ltArT1Yp8SulFZU79B13QdvAgJDOww irY0DudZTWd6vffB8o1iJL1RQW4lQcWtb25lzRY6DspHbF81SCKATfi7/KIMvFKTrtRQ Tg/edotPYMZGobDs2CCqViRriAGPQ9FZmZ7amlRcbURJ6gu33ePvWOUcE+baoi7HB4PM 34Lg== X-Gm-Message-State: ANhLgQ20bLmtMXnZfF2xCgoo4T/czxZk1CmC9SKCKR4hUQO6Bv7MdkJO iDMB7H/rbw8HRAvjIFHMsNrLo+A2+cGf0GOm101zgHDp X-Google-Smtp-Source: ADFU+vsJNpxYZDFrMHokhilNDOkREcnuNQPg7EC13cR5S95ieGDo6FwN5LpogJmwwfkBQhDeN1WJd++nAiRqfiatfVE= X-Received: by 2002:a9d:369:: with SMTP id 96mr304172otv.174.1584466544734; Tue, 17 Mar 2020 10:35:44 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177463 Archived-At: Am Di., 17. M=C3=A4rz 2020 um 18:15 Uhr schrieb Philipp Stephani : > > > Make sure that git isn't installed, e.g. by running 'apt remove git' on > a Debian system. Then, in the Emacs source test directory: > > $ make lisp/simple-tests SELECTOR=3Dsimple-delete-trailing-whitespace--bu= g-21766 > make[1]: Entering directory '/emacs/test' > GEN lisp/simple-tests.log > Running 1 tests (2020-03-17 18:07:31+0100, selector `simple-delete-traili= ng-whitespace--bug-21766') > Test simple-delete-trailing-whitespace--bug-21766 backtrace: > call-process("git" nil (t nil) nil "rev-parse" "--abbrev-ref" "HEAD" > emacs-repository-branch-git("/emacs/") > emacs-repository-get-branch("/emacs/") > byte-code("\3021$\0\303\304\305\306!\307\"\206\17\0\10\1\31\211;\205 > (defconst tramp-repository-branch (byte-code "\3021$\0\303\304\305\3 > require(trampver) > byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\305\ > require(tramp) > require(tramp-sh) > byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\300\ > (python-mode) > (progn (python-mode) (insert (concat "query =3D \"\"\"WITH filtered AS > (unwind-protect (progn (python-mode) (insert (concat "query =3D \"\"\" > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-b > (unwind-protect (let ((temp-buffer (generate-new-buffer " *temp*"))) > (let ((python (featurep 'python)) (python-indent-guess-indent-offset > (closure (t) nil (defvar python-indent-guess-indent-offset) (let ((p > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name simple-delete-trailing-whitespace--bu > ert-run-or-rerun-test(#s(ert--stats :selector simple-delete-trailing > ert-run-tests(simple-delete-trailing-whitespace--bug-21766 #f(compil > ert-run-tests-batch(simple-delete-trailing-whitespace--bug-21766) > ert-run-tests-batch-and-exit(simple-delete-trailing-whitespace--bug- > eval((ert-run-tests-batch-and-exit 'simple-delete-trailing-whitespac > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/simple-tests.el" "-- > command-line() > normal-top-level() > Test simple-delete-trailing-whitespace--bug-21766 condition: > (file-missing "Searching for program" "No such file or directory" "gi= t") > FAILED 1/1 simple-delete-trailing-whitespace--bug-21766 (0.267653 se= c) > > Ran 1 tests, 0 results as expected, 1 unexpected (2020-03-17 18:07:32+010= 0, 1.093014 sec) > > 1 unexpected results: > FAILED simple-delete-trailing-whitespace--bug-21766 > > make[1]: *** [Makefile:183: lisp/simple-tests.log] Error 1 > make[1]: Leaving directory '/emacs/test' > make: *** [Makefile:249: lisp/simple-tests] Error 2 > > > This is weird because trampver.el properly uses ignore-errors, so this > error shouldn't bubble up. Ah, the problem is that with-demoted-errors uses condition-case-unless-debug. More minimal example: $ emacs -Q -batch -eval '(let ((debug-on-error t)) (ignore-errors (with-demoted-errors "%S" (error "foo"))))' Debugger entered--Lisp error: (error "foo") [=E2=80=A6] I think this behavior is very confusing. Both version.el and trampver.el try to do the right thing, but that breaks in such a situation.