From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) Date: Sat, 22 Dec 2018 23:26:11 +0100 Message-ID: References: <8336qwdixp.fsf@gnu.org> <20181217204746.53492-1-phst@google.com> <831s6aaq06.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1545517512 27893 195.159.176.226 (22 Dec 2018 22:25:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 22:25:12 +0000 (UTC) Cc: Philipp Stephani , 28691-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 23:25:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaphi-00075O-OG for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 23:25:06 +0100 Original-Received: from localhost ([::1]:37043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gapjp-0000Js-DA for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 17:27:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gapjd-0000Gm-II for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 17:27:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gapja-0000mc-D1 for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 17:27:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gapja-0000mW-9I for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 17:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gapja-0005lE-4W for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 17:27:02 -0500 Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 22:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 28691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 28691@debbugs.gnu.org, p.stephani2@gmail.com, monnier@iro.umontreal.ca Original-Received: via spool by 28691-done@debbugs.gnu.org id=D28691.154551759022099 (code D ref 28691); Sat, 22 Dec 2018 22:27:01 +0000 Original-Received: (at 28691-done) by debbugs.gnu.org; 22 Dec 2018 22:26:30 +0000 Original-Received: from localhost ([127.0.0.1]:60287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gapj4-0005kN-6V for submit@debbugs.gnu.org; Sat, 22 Dec 2018 17:26:30 -0500 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:39175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gapj2-0005kB-Q1 for 28691-done@debbugs.gnu.org; Sat, 22 Dec 2018 17:26:29 -0500 Original-Received: by mail-ot1-f45.google.com with SMTP id n8so8299880otl.6 for <28691-done@debbugs.gnu.org>; Sat, 22 Dec 2018 14:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3LG/1RN7zi/LlXqBRboSJeHwuG4V11Ow9GStDk8+5g8=; b=cgTwIwK2yW52olSIdN3oSIAPteDyGJz99AtL39z6OtnrXIxtpF6BEr8l88lLMWsfc+ oUQBjPVfcqWB2vlxNhGfCOpltAGq1werhffY4Qj+kfMOdUVpUqJXoHV+JO21tjzAc6lO L+spFN7tMIpLIgWCpxLvN2e84hIP+BNjrCpHDgVLJVT7adxsiq/smIXcI3ncGCSEhNYW xLUh+HCT31qpkp3Y9n5KEDtoomZMXJtHV6HbBToQCKsxB1bGONGb9Ov0P4zfYkJnollm K8OSr3MLiAzzgqoOiH7sxaAGOG4w+gxaUrtaOCuNvj7tsxKGoWbuyhUefEevzNMZPket K6Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3LG/1RN7zi/LlXqBRboSJeHwuG4V11Ow9GStDk8+5g8=; b=bYmtQxnBhECPoOg1FAFFWQJzOWRyJH+ZsVyUzjRJ+8KTls6HEtw423ztWamn8GqlR7 6oPxKCRJvKmZrj8/pRWUvCc0qCjvxTJZGWJYucipRWst1GVeINjrVyxgxQ/7sqgNXxZB 92+3/NMQJyDOzsCMmOKFn0TMLpO54h4nk6ZPBv4baEy5kzuPy7UzJG+lN1ygfVtJQIJs Uz+3KDU+GfxrCoQ+kpfeqIzVGj99dBEVVUqY8T0Q0OqGdMUBSuV0kSw18z3jaENeoH2F ifud3WvMJLdoTHYvYQHpWtx+737fNaL4yuXIo/A3KBurpmn4kQvhjg8rRbv8ywlQ7GEs VwQg== X-Gm-Message-State: AJcUukcuBXJn7vvSnufvPT3iHNB0l5GN6i5c2Oeui3PzG+yGYbqEmI7D /6f4KunbigGqDp2dmI0sjzeT+VDBoIiLFX2i9lE= X-Google-Smtp-Source: ALg8bN5tqbsplEda6ruMQGE5w2fAF9mWL3de9scIJH+dPyx+mQRnTf325RA5D+vP3zMc9Rzn5+vUlVQ5IG9NbaJLkGU= X-Received: by 2002:a9d:60cf:: with SMTP id b15mr5036900otk.144.1545517582878; Sat, 22 Dec 2018 14:26:22 -0800 (PST) In-Reply-To: <831s6aaq06.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153759 Archived-At: Am Sa., 22. Dez. 2018 um 10:09 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Cc: 28691@debbugs.gnu.org, > > Philipp Stephani > > Date: Mon, 17 Dec 2018 21:47:46 +0100 > > > > * src/process.c (Fmake_process): Add new keyword argument > > ':file-handler'. > > (syms_of_process) : Define new symbols. > > > > * lisp/files.el (file-name-non-special): Add support for > > 'make-process'. > > > > * test/src/process-tests.el (make-process/file-handler/found) > > (make-process/file-handler/not-found) > > (make-process/file-handler/disable): New unit tests. > > (process-tests--file-handler): New helper function. > > > > * test/lisp/files-tests.el > > (files-tests-file-name-non-special-make-process): New unit test. > > > > * doc/lispref/files.texi (Magic File Names): Document that > > 'make-process' can invoke file name handlers. > > > > * doc/lispref/processes.texi (Asynchronous Processes): Document > > ':file-handlers' argument to 'make-process'. > > Thanks, this LGTM, but some of the tests use the Emacs binary, while > others still use /bin/true for some reason. What am I missing? The one that uses /bin/true never invokes it, but only tests whether the full argument list is passed to the handler. I've changed this now to /some/binary to clarify that the actual string doesn't matter. > > Please also include etc/NEWS change in the log message. > Done and pushed as 039be4e025. Thanks!