From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#20852: [PATCH] Warn about missing backslashes during load Date: Mon, 01 May 2017 18:41:07 +0000 Message-ID: References: <20170501142718.3510-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0d21c2d5e417054e7ac4f8 X-Trace: blaine.gmane.org 1493664139 32350 195.159.176.226 (1 May 2017 18:42:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 May 2017 18:42:19 +0000 (UTC) Cc: Philipp Stephani To: Stefan Monnier , 20852-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 01 20:42:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5GGw-0008Bt-VH for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 20:42:11 +0200 Original-Received: from localhost ([::1]:55393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5GH0-0002q4-Lw for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 14:42:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5GGs-0002po-Q6 for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:42:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5GGo-00068f-38 for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:42:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5GGn-00068b-Ui for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5GGn-0000RN-Ix for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2017 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug wontfix Original-Received: via spool by 20852-done@debbugs.gnu.org id=D20852.14936640861647 (code D ref 20852); Mon, 01 May 2017 18:42:01 +0000 Original-Received: (at 20852-done) by debbugs.gnu.org; 1 May 2017 18:41:26 +0000 Original-Received: from localhost ([127.0.0.1]:49916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5GGD-0000QV-RC for submit@debbugs.gnu.org; Mon, 01 May 2017 14:41:26 -0400 Original-Received: from mail-wr0-f179.google.com ([209.85.128.179]:36618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5GGC-0000QI-NI for 20852-done@debbugs.gnu.org; Mon, 01 May 2017 14:41:25 -0400 Original-Received: by mail-wr0-f179.google.com with SMTP id l50so67013940wrc.3 for <20852-done@debbugs.gnu.org>; Mon, 01 May 2017 11:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xoSq+JRoHLtYmKxOQ8faa6TE/BYKECM+IzsW2PFZ8Gg=; b=K3t9OuvWwa67b7BizRQudCTF1hG2DkSmn4LZN7QPt013cqzOEJ/7gc1Vv51/6hNDsZ 6aYaMREjrw+9xiudEFhFXFThS6xW5JuVp+y+9mdDkSRI74A01B9kssaPBl98awBMT7Pw fZr/wNkoTVaSOY/rAfT75ndoTD17QmOTvpdNz4KvtXigDiAy+tJzsAmTkvJOXjZZu6Wt RECLaFi0cWIWQerFTpmFkhlcFPgzfqzYg87d1X796eoT6V1kW1GHJXFKxw8sqbyVC6wm 4ZO1MViNhLDbWQP2GC6DhTXuk+pNy0xjuKzNqAQLqt/+yBZ4pqedJpbIHLZ11zVdcmw8 SfRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xoSq+JRoHLtYmKxOQ8faa6TE/BYKECM+IzsW2PFZ8Gg=; b=oFRmCH5xTgMiyrek1AzeYlssp2OaA+9s07AtpsMlOnpCqRBxtmG9KpYINGvtak95Bd 194dhECxD3HpinGkxGFOEZpJbTX8FkI703cIk6BhO9X9JAH10ln1XAar+UfeCgPcGLfM Azm4Cui284jOKbYILFWV9kYpLEFijQIeMEOKlAqT5SWzEIBbXe/FMjTZQlLVoKQYvypu +YEuWfJT6XxGH3Xo/Ip5xTOTSmxKWb6rKIcCVY/4S8np6gd84ofWIU/yXsBcALh2Xdm8 SQl5fyQoWVui6/bZHx/c1bFXDbbtBedxOASCwKW8VTsg8ARJjHc/xDajRMVeQ8ZHr8mh Q7Dg== X-Gm-Message-State: AN3rC/5UDU5OlUo8TP167AWgQLLYLmLha7xOYmYVj+5tpqAumoeufyn2 XCwkQxN9FZ+pb46Wt0VkCTaXKP+8cg== X-Received: by 10.223.148.35 with SMTP id 32mr10327100wrq.175.1493664078880; Mon, 01 May 2017 11:41:18 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132169 Archived-At: --94eb2c0d21c2d5e417054e7ac4f8 Content-Type: text/plain; charset=UTF-8 Stefan Monnier schrieb am Mo., 1. Mai 2017 um 19:59 Uhr: > Looks great, thank you very much. See comments below. > > > + if (c == '(' || c == ')' || c == '[' || c == ']' > > + || c == '"' || c == ';') > > These are indeed the most important ones w.r.t elisp-mode's > syntax-table, but I think we should put #, ?, and ' in there as well. > This said, maybe we should add chars in there "little by little" to try > and not overwhelm people with warnings. > So the above set might actually be a good set with which to start. > Yeah, I've left it as-is for now, the current set are those characters that cause problems in practice (wrong paren highlighting, confusion with paredit). > > > + doc: /* List of deprecated unescaped character literals > encountered by `read'. For internal use only. */); > > Please keep the first line of docstrings with 80 columns. I.e. move the > "For internal use only." to a second line. > > Done and pushed as c2bbdc3316. --94eb2c0d21c2d5e417054e7ac4f8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Stefan= Monnier <monnier@iro.umontr= eal.ca> schrieb am Mo., 1. Mai 2017 um 19:59=C2=A0Uhr:
Looks great, thank you very much.=C2=A0 See comm= ents below.

> +=C2=A0 =C2=A0 =C2=A0if (c =3D=3D '(' || c =3D=3D ')' = || c =3D=3D '[' || c =3D=3D ']'
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 || c =3D=3D '"'= ; || c =3D=3D ';')

These are indeed the most important ones w.r.t elisp-mode's
syntax-table, but I think we should put #, ?, and ' in there as well. This said, maybe we should add chars in there "little by little" = to try
and not overwhelm people with warnings.
So the above set might actually be a good set with which to start.

Yeah, I've left it as-is for now, the curre= nt set are those characters that cause problems in practice (wrong paren hi= ghlighting, confusion with paredit).
=C2=A0

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0doc: /* List o= f deprecated unescaped character literals encountered by `read'.=C2=A0 = For internal use only.=C2=A0 */);

Please keep the first line of docstrings with 80 columns.=C2=A0 I.e. move t= he
"For internal use only." to a second line.


Done and pushed as c2bbdc3316.=C2=A0
--94eb2c0d21c2d5e417054e7ac4f8--