all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, 20852-done@debbugs.gnu.org
Cc: Philipp Stephani <phst@google.com>
Subject: bug#20852: [PATCH] Warn about missing backslashes during load
Date: Mon, 01 May 2017 18:41:07 +0000	[thread overview]
Message-ID: <CAArVCkQiL+9GV4GfK4MNyOwhsXp5uxt_D67AWzg9YqbHzxnLjg@mail.gmail.com> (raw)
In-Reply-To: <jwv7f20lb8v.fsf-monnier+emacsbugs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> schrieb am Mo., 1. Mai 2017 um
19:59 Uhr:

> Looks great, thank you very much.  See comments below.
>
> > +     if (c == '(' || c == ')' || c == '[' || c == ']'
> > +            || c == '"' || c == ';')
>
> These are indeed the most important ones w.r.t elisp-mode's
> syntax-table, but I think we should put #, ?, and ' in there as well.
> This said, maybe we should add chars in there "little by little" to try
> and not overwhelm people with warnings.
> So the above set might actually be a good set with which to start.
>

Yeah, I've left it as-is for now, the current set are those characters that
cause problems in practice (wrong paren highlighting, confusion with
paredit).


>
> > +               doc: /* List of deprecated unescaped character literals
> encountered by `read'.  For internal use only.  */);
>
> Please keep the first line of docstrings with 80 columns.  I.e. move the
> "For internal use only." to a second line.
>
>
Done and pushed as c2bbdc3316.

[-- Attachment #2: Type: text/html, Size: 1622 bytes --]

  reply	other threads:[~2017-05-01 18:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19 19:22 bug#20852: 24.3; update-file-autoloads doesn't accept unescaped parenthesis character literal Philipp Stephani
2015-06-19 21:24 ` Stefan Monnier
2015-06-21 12:13   ` Philipp Stephani
2015-06-22  1:18     ` Stefan Monnier
2015-06-28 13:12       ` Philipp Stephani
2015-06-30 20:43         ` Philipp Stephani
2015-07-02 15:50           ` Stefan Monnier
     [not found]             ` <20170501142718.3510-1-phst@google.com>
2017-05-01 17:59               ` bug#20852: [PATCH] Warn about missing backslashes during load Stefan Monnier
2017-05-01 18:41                 ` Philipp Stephani [this message]
2017-05-06 21:14             ` [PATCH] Make `old-style-backquotes' variable internal Philipp
2017-05-07  2:31               ` Eli Zaretskii
2017-05-07 11:49                 ` Philipp
2017-05-13 10:35                   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAArVCkQiL+9GV4GfK4MNyOwhsXp5uxt_D67AWzg9YqbHzxnLjg@mail.gmail.com \
    --to=p.stephani2@gmail.com \
    --cc=20852-done@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.