From: Philipp Stephani <p.stephani2@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: Patch to have let and let* test that the arglist is a list
Date: Wed, 18 Jan 2017 18:53:22 +0000 [thread overview]
Message-ID: <CAArVCkQhUy1CBLibLewU-P+Ld5peBPvA5STmhtGHVXdRQgdKog@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 113 bytes --]
Hi,
I've attached a small patch for let and let* to make them check for the
type of the argument list.
Philipp
[-- Attachment #1.2: Type: text/html, Size: 186 bytes --]
[-- Attachment #2: 0001-Check-that-variable-lists-are-actually-lists.txt --]
[-- Type: text/plain, Size: 1843 bytes --]
From 84ad5052fd65053a665219897883fdee88a3409c Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Wed, 18 Jan 2017 19:49:58 +0100
Subject: [PATCH] Check that variable lists are actually lists
'let' and 'let*' document that their first argument has to be a list,
but don't check for that; instead, they allow (and silently ignore)
other types. Introduce an explicit type check.
* src/eval.c (Flet, FletX): Check that the variable list is indeed a
list.
* test/src/eval-tests.el: Add unit tests.
---
src/eval.c | 2 ++
test/src/eval-tests.el | 10 ++++++++++
2 files changed, 12 insertions(+)
diff --git a/src/eval.c b/src/eval.c
index 1f8d409932..c05c8d8f8d 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -857,6 +857,7 @@ usage: (let* VARLIST BODY...) */)
lexenv = Vinternal_interpreter_environment;
varlist = XCAR (args);
+ CHECK_LIST (varlist);
while (CONSP (varlist))
{
QUIT;
@@ -917,6 +918,7 @@ usage: (let VARLIST BODY...) */)
USE_SAFE_ALLOCA;
varlist = XCAR (args);
+ CHECK_LIST (varlist);
/* Make space to hold the values to give the bound variables. */
elt = Flength (varlist);
diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el
index a1fe8ccd7d..95655eac82 100644
--- a/test/src/eval-tests.el
+++ b/test/src/eval-tests.el
@@ -47,4 +47,14 @@
(let ((byte-compile-debug t))
(should-error (eval `(byte-compile (lambda ,args)) t)))))
+
+(dolist (form '(let let*))
+ (dolist (arg '(1 "a" [a]))
+ (eval
+ `(ert-deftest ,(intern (format "eval-tests--%s--%s" form (type-of arg))) ()
+ ,(format "Check that the first argument of `%s' cannot be a %s"
+ form (type-of arg))
+ (should-error (,form ,arg) :type 'wrong-type-argument))
+ t)))
+
;;; eval-tests.el ends here
--
2.11.0.483.g087da7b7c-goog
next reply other threads:[~2017-01-18 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 18:53 Philipp Stephani [this message]
2017-01-18 21:25 ` Patch to have let and let* test that the arglist is a list Alan Mackenzie
2017-01-19 3:52 ` John Wiegley
2017-01-19 16:24 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkQhUy1CBLibLewU-P+Ld5peBPvA5STmhtGHVXdRQgdKog@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.