bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding

bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding

[Gemini Lasswell]

On loading the file test/lisp/progmodes/cc-mode.el, Emacs gives the
warning that the local variables list may not be safe. Looks like a
typo. Also, the first line of the file refers to cc-mode-tests.el but
the file is called cc-mode.el. IMO cc-mode-tests.el would be a better
name for this file and more consistent with other file names in the test
directory.

bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding

[Philipp Stephani]

[-- Attachment #1.1: Type: text/plain, Size: 525 bytes --]

Gemini Lasswell <gazally@runbox.com> schrieb am Do., 20. Okt. 2016 um
19:55 Uhr:

> On loading the file test/lisp/progmodes/cc-mode.el, Emacs gives the
> warning that the local variables list may not be safe. Looks like a
> typo. Also, the first line of the file refers to cc-mode-tests.el but
> the file is called cc-mode.el. IMO cc-mode-tests.el would be a better
> name for this file and more consistent with other file names in the test
> directory.
>
>
>
Thanks for reporting. I've attached a patch to fix these issues.

[-- Attachment #1.2: Type: text/html, Size: 967 bytes --]

[-- Attachment #2: 0001-Minor-fixes-to-cc-mode-tests.el.txt --]
[-- Type: text/plain, Size: 1505 bytes --]

From 56f8384bb3f20d55693a3a1db8aa2cf490e6d18e Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Thu, 20 Oct 2016 20:22:40 +0200
Subject: [PATCH] Minor fixes to cc-mode-tests.el

See Bug#24747.

* progmodes/cc-mode-tests.el: Rename from cc-mode.el; fix typo in
file-local variable; add comments to make checkdoc happy.
---
 test/lisp/progmodes/{cc-mode.el => cc-mode-tests.el} | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
 rename test/lisp/progmodes/{cc-mode.el => cc-mode-tests.el} (96%)

diff --git a/test/lisp/progmodes/cc-mode.el b/test/lisp/progmodes/cc-mode-tests.el
similarity index 96%
rename from test/lisp/progmodes/cc-mode.el
rename to test/lisp/progmodes/cc-mode-tests.el
index 6cd9fa4..62e0a73 100644
--- a/test/lisp/progmodes/cc-mode.el
+++ b/test/lisp/progmodes/cc-mode-tests.el
@@ -1,4 +1,4 @@
-;;; cc-mode-tests.el --- Test suite for cc-mode.  -*- lexical-binning: t -*-
+;;; cc-mode-tests.el --- Test suite for cc-mode.  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2016 Free Software Foundation, Inc.
 
@@ -21,6 +21,11 @@
 ;; You should have received a copy of the GNU General Public License
 ;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
 
+
+;;; Commentary:
+
+;; Unit tests for cc-mode.el.
+
 ;;; Code:
 
 (require 'ert)
@@ -63,3 +68,5 @@
             '("struct \t Blah_42 \t {"
               "struct template {"
               "#include <string.h>")))))
+
+;;; cc-mode-tests.el ends here
-- 
2.8.0.rc3.226.g39d4020

bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Thu, 20 Oct 2016 18:29:38 +0000
> 
>  On loading the file test/lisp/progmodes/cc-mode.el, Emacs gives the
>  warning that the local variables list may not be safe. Looks like a
>  typo. Also, the first line of the file refers to cc-mode-tests.el but
>  the file is called cc-mode.el. IMO cc-mode-tests.el would be a better
>  name for this file and more consistent with other file names in the test
>  directory.
> 
> Thanks for reporting. I've attached a patch to fix these issues. 

For such obvious typo-like problems, please just push the fix right
away.

Thanks.

bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Eli Zaretskii <eliz@gnu.org> schrieb am Do., 20. Okt. 2016 um 21:27 Uhr:

> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Thu, 20 Oct 2016 18:29:38 +0000
> >
> >  On loading the file test/lisp/progmodes/cc-mode.el, Emacs gives the
> >  warning that the local variables list may not be safe. Looks like a
> >  typo. Also, the first line of the file refers to cc-mode-tests.el but
> >  the file is called cc-mode.el. IMO cc-mode-tests.el would be a better
> >  name for this file and more consistent with other file names in the test
> >  directory.
> >
> > Thanks for reporting. I've attached a patch to fix these issues.
>
> For such obvious typo-like problems, please just push the fix right
> away.
>
>
Pushed to master.

[-- Attachment #2: Type: text/html, Size: 1443 bytes --]

bug#24747: 26.0.50; test/lisp/progmodes/cc-mode.el sets lexical-binning not lexical-binding

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Thu, 20 Oct 2016 19:34:54 +0000
> Cc: gazally@runbox.com, "24747@debbugs.gnu.org" <24747@debbugs.gnu.org>, 24747-done@debbugs.gnu.org
> 
>  > On loading the file test/lisp/progmodes/cc-mode.el, Emacs gives the
>  > warning that the local variables list may not be safe. Looks like a
>  > typo. Also, the first line of the file refers to cc-mode-tests.el but
>  > the file is called cc-mode.el. IMO cc-mode-tests.el would be a better
>  > name for this file and more consistent with other file names in the test
>  > directory.
>  >
>  > Thanks for reporting. I've attached a patch to fix these issues.
> 
>  For such obvious typo-like problems, please just push the fix right
>  away.
> 
> Pushed to master. 

Thanks.