From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] Don't print "process finished" into the stderr buffer. Date: Fri, 19 Apr 2019 21:28:32 +0200 Message-ID: References: <20180404120218.257212-1-phst@google.com> <20180404120218.257212-2-phst@google.com> <834lkr3ygo.fsf@gnu.org> <83lgdxzvs2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142946"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 19 21:29:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHZCd-000b2V-P1 for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 21:29:39 +0200 Original-Received: from localhost ([127.0.0.1]:60582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHZCc-0003Ya-PP for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 15:29:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHZBn-0003YV-KT for emacs-devel@gnu.org; Fri, 19 Apr 2019 15:28:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHZBm-0004sj-L8 for emacs-devel@gnu.org; Fri, 19 Apr 2019 15:28:47 -0400 Original-Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:35566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHZBk-0004r7-EG; Fri, 19 Apr 2019 15:28:44 -0400 Original-Received: by mail-ot1-x343.google.com with SMTP id m10so5085936otp.2; Fri, 19 Apr 2019 12:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R70HmOy3gwx34nR3515db2mUChzUiRjTJ4RfbL/ZVzo=; b=XVF0x3To1z0AF+qRpTRs6NAcrT1sy4xBnAFe641gTflScDbv/AfsvH6CUvY608h29u QJ81epyPsnYTvUbmFcaLCpBwhv3c2vh307nq4P9s2dGla4B14UdJDhuDpYSXNFgM1wp8 pNzZlUTwSqotli/XeBVJOfXPiPkiEqLN7X26cDqI/7zSa2JB4uEVMpCzghLs4F/sj9Kq hz9H6NNqYC897lXm3Ju0WUUrQ7hY2uNSL6gWt/KXo3cYO/6cOKYnUZrzV3M79Yto54g+ t4JVrgdVcvlHy9vcR5JhX/gf54M0AYSgiXJXvTaWWR9im1qhilom7eSGjqzGi3a8N8to giug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R70HmOy3gwx34nR3515db2mUChzUiRjTJ4RfbL/ZVzo=; b=XUiKCB62mQdG+5pl6A3239D8JC1/bvlMLYv8S0olWBSRnMZSimg/xMFTwt2AxtICWp HPe2lco1tTg7DfsTM126dJcq2jyOhGv2m7LJJOP8LvlZBtvh0KcyjOeliNv30Xf5RKP+ xXbO7Ci1eO4XmAB9e9RXOMRqyVoYKNCCG3gWDs8rLnY+fY3zFgexyD0WCprOBVu+4a95 F4lb/B3GmslNnoT98Q9ZTMpLNvJ6QuSARdO1ZKXLsZnPsXUafq4YxvZuu83AN+QrRj5A HJBJLHrO6cnQ0xOYj2No+OY8KDBjmrQl+cVtwRj1k/MJLuEkCsTwLGdJJ71GyzsanvOd XniQ== X-Gm-Message-State: APjAAAUfP0LPmAKnvR+YsMgvXeMQpMwkl50sgsR8s8ixiWYodwX0Ae7G 6Ky3Db7k7SVpvKIh9z4TCIbyEsKZgXyq+b9P7mYhXA== X-Google-Smtp-Source: APXvYqzDJPEoj5rxwg5ydPdeYJLUSkwFfhascRumTo6ozNTKmnxGTRSL1NX0RP3Bnt47LAptb4MMdey14DsOApUfCd0= X-Received: by 2002:a05:6830:15d2:: with SMTP id j18mr3018209otr.37.1555702123046; Fri, 19 Apr 2019 12:28:43 -0700 (PDT) In-Reply-To: <83lgdxzvs2.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::343 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235671 Archived-At: Am So., 8. Apr. 2018 um 15:13 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Sat, 07 Apr 2018 20:21:40 +0000 > > Cc: emacs-devel@gnu.org, phst@google.com > > > > > * src/process.c (syms_of_process): Add 'ignore' symbol. > > > (Fmake_process): Use it as sentinel for the standard error pipe > > > process. > > > > Why would we want that, and by default on top of that? Please give at > > least some rationale behind this change. > > > > Neither the manual not the docstring for `make-process' specify that Emacs prints "Process foo stderr > > finished" at the end of the standard error buffer, so that message shouldn't be printed. > > That assumes that the documentation is correct and the code isn't; it > could be the other way around. Sure. My opinion is that the documentation is correct (albeit incomplete), and the code is slightly buggy. > > But I'm guessing that the current behavior was unexpected for some > reason, and that's why you looked in the documentation. If the guess > is correct, could you describe why it was unexpected/unwanted? It's unexpected that Emacs writes something. This is an instance of the general case that by default you expect nothing to happen instead of something, unless you request the "something". For example, after $ echo foo > bar would you expect that the file "bar" contains content other than "foo\n" because the shell decides to write additional text before closing redirections? This is the same thing. The documentation for make-process doesn't state that if :stderr is a buffer, make-process creates a pipe process with the default sentinel; rather it treats that pipe process as implementation detail (which is OK-ish), so users don't expect the default sentinel to run for the stderr buffer.