From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: What's the line length limit in the Emacs codebase? Date: Fri, 25 Dec 2020 18:10:50 +0100 Message-ID: References: <83wnx8pm0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25502"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 25 18:12:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksqdO-0006Yy-IB for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Dec 2020 18:12:10 +0100 Original-Received: from localhost ([::1]:57892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksqdN-0000RE-Jb for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Dec 2020 12:12:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksqcW-0008QO-6c for emacs-devel@gnu.org; Fri, 25 Dec 2020 12:11:16 -0500 Original-Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]:39346) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ksqcJ-0001cb-Gu; Fri, 25 Dec 2020 12:11:15 -0500 Original-Received: by mail-oi1-x229.google.com with SMTP id w124so5226459oia.6; Fri, 25 Dec 2020 09:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rzWpmhDeJInVjLqicwso2Bn2bPLjXoYbSbbnuYr6LI0=; b=BlxYck3DJ9ckwPfOd46IDUinGSB5Mza75ZFb7j6cZ7+HOIYIoggGNWt3THTR3A8RGr RmgGb90t6QioRdjecQ9zAyyVyyO7BU/vZXd088o+3WzbAcTpUl58+9Ui7Y3uti25xFGg OYxedmXcRHmDaKmhSJsPOxxXuQHeIHHUJlX8Txawh3sT+Z/MfLugU55uCmroLkSa1tgc m5BiPmS/KcvMMvqCIjHwFJNneo8Bh718qt1sgAyMphwvTm3rq2z/4EzJRzld8SGwDkBN K27nzeVLnKNCViMRIAKash5po+4Tf9xbPCv2ePiVLuE2Ip5bNf4AaAt6a1vsfeVd0qsy JPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rzWpmhDeJInVjLqicwso2Bn2bPLjXoYbSbbnuYr6LI0=; b=cT6FgIxljhBQyj2V4V0vq+FCS2H2GAYO+ZZ7QsG++xUkGHWo7DnkayaoAMr2retE3H HHLmnhasYZs2C1hQmI6WWPxLRwyHYVi603aEigV9HJOJgYCSWhlcZgbVxhlQ38sGa0UZ ojKTuNKF1tvoiC4nXTJMq9AjVE1Y4a9spCpGWcttzB5AiRPpoWLmqsJW5A6CESgr06wB IP0k6niMVrKht37rZ9nYr8emb+LoqDKYxg5AFFhgJYu29weXdJd06rtxZNEvF7DwM9yY jJAZrAqzkimZ50tzUEFyHMMYWVDd+ux440wuuv1EhPtPun8G6nxaYFuOkAghOL5HQqkK rDmQ== X-Gm-Message-State: AOAM5311uIu2g9Qe7/ct4YLHQ5LO9xkYx14Agp4I4MzackBqvEx1Riq3 m/oQUyVSYPKegurEk/N9VW4MLIvik+A3J2NDmw0ScK5Fe8Y= X-Google-Smtp-Source: ABdhPJyVV2c0U0ARhBkckpvWqaCYeGr2l8fNPUAycT7VKegu2BNfn8TRk+JHWbKmU9nWXjkN67rUNwNyMV088uJM1JQ= X-Received: by 2002:aca:3a02:: with SMTP id h2mr5589076oia.65.1608916261747; Fri, 25 Dec 2020 09:11:01 -0800 (PST) In-Reply-To: <83wnx8pm0e.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::229; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x229.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261752 Archived-At: Am Mi., 23. Dez. 2020 um 16:42 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Wed, 23 Dec 2020 10:58:32 +0100 > > > > There seem to be conflicting settings for the line length limit in the > > Emacs codebase: .dir-locals.el sets fill-column to 70, but large areas > > of the source code (including comments) seem to use 80. Can we pick > > one value and use it consistently (for new/changed code)? > > 70 is it, we just don't necessarily enforce it religously. > > Where did you see significant deviations from that standard? Everywhere? When I last counted there were more than 1900 files in the codebase that have lines longer than 70 characters. In src/emacs.c alone there are over 160 such lines.