From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add a new user option 'ido-big-directories'. Date: Wed, 17 Apr 2019 20:30:55 +0200 Message-ID: References: <20190412122301.98921-1-phst@google.com> <835zrjmlbj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103338"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 17 20:31:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGpLA-000Qgs-Fi for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 20:31:24 +0200 Original-Received: from localhost ([127.0.0.1]:57841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGpL9-0000uq-FT for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 14:31:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGpL3-0000uV-53 for emacs-devel@gnu.org; Wed, 17 Apr 2019 14:31:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGpL1-0007IE-60 for emacs-devel@gnu.org; Wed, 17 Apr 2019 14:31:17 -0400 Original-Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]:39876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGpKv-0007Ev-Iu; Wed, 17 Apr 2019 14:31:10 -0400 Original-Received: by mail-oi1-x242.google.com with SMTP id n187so20843232oih.6; Wed, 17 Apr 2019 11:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HpGJwkcxdVFTiLIT6HzIiQ8GAyoU0tj2y61YTA3UHiM=; b=TjMB/ZopxGLjUTBwYjpr9bDIJClPxvPiZMxfplEiu0rhmjJixI2uZ21lGF17nMNnoh cp7SXTBIaMVCGnbhSVM+IujnSk3Xn4cAF1r0ynC555prHJXfhQcJDjpCpD2Mgbs/9RPS NFfBQHSzcGOIQ1B3CJdCMDoU4IxgbTrJTD8mqccwoDP4QsYcNGTQAs8rDvDYSSv8hLKD CqoSS4PG31iviJNHLrhtzs9QSjae16eEsSCFQ6OsBP7Js8+ln6qvnrXCtPQUdnB8PWlZ 5Hs6pipKvaystjnr4uDaLf0dIwEIrnCSvtGToJVrxhRUpdfWTTFnGw4bQjm6Lc6nI02Z 4foA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HpGJwkcxdVFTiLIT6HzIiQ8GAyoU0tj2y61YTA3UHiM=; b=RTa8JWvULhUe6BEHZc0pBl1DVKysClGj06z83qJSf82E6ZTgJ0/zf7qKGH7lAPWEW4 7Pj8Hbo9qUQHvbH3/y1gmBpDknFo5cIgHhdF0QQddzU0jWCR23JDDpLgO7vDsr2hdWVI kvhFkI/T8yHVJPe8jVyzRejKs5AlQZaK5XRLhyG31CTd6JmOiy4Qjvf55hp7AywKZd+Z OuBiSAestAhGyDXVLdujVqh/7jqjtX/9/MX3/wrIQExi9J1btwT5c23lPXog+hWi/iS6 ShjUyAnfT5Udx45U/42lnwrZ6oRpfmizIUSnPVJqWq4Bo6EsFFE8P9tHiGdbhxb0xB93 lb0A== X-Gm-Message-State: APjAAAU0Yq6pLRNZ7g8DG/F3JSaGqTJpMPOKB+tWx5FyA8n1nMyiEkBj PbvZZ9uOJJ9jiEyz+icZPUL3m/107AIUiJT/5y0j2Q== X-Google-Smtp-Source: APXvYqx0kwwYd5GFmLk0YawiSO7/lmH6Cz2vudVI4X8LDy8xSPGAt0W/iU4WZQMkmTOQYad2WcXLr0Bg5C0F30FOiO0= X-Received: by 2002:aca:5784:: with SMTP id l126mr6180oib.170.1555525866845; Wed, 17 Apr 2019 11:31:06 -0700 (PDT) In-Reply-To: <835zrjmlbj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235601 Archived-At: Am Fr., 12. Apr. 2019 um 14:59 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Fri, 12 Apr 2019 14:23:01 +0200 > > Cc: Philipp Stephani > > > > This provides an alternative to 'ido-max-directory-size', for > > directories that are statically known to be too big for Ido > > completion. > > Thanks. > > > +** Ido > > +*** New user option 'ido-big-directories' to mark certain directory > > +patterns as big. > > This doesn't say what is a "pattern" and what is the meaning of "big" > in this context. Could that be at least hinted at? > > > +(defcustom ido-big-directories nil > > + "Additional directories that should be considered big. > > +Ido will ignore directories matching any of these regular > > +expressions." > > The doc string should explicitly say what is the form of the value. > Also, since the elements of the sequence are regular expressions, the > first sentence should mention that, or at least say they are strings. Thanks, I'll send a new patch.