From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#44341: 27.1; define-minor-mode generates inaccurate docstring Date: Mon, 2 Nov 2020 13:28:06 +0100 Message-ID: References: <87361u64oo.fsf@thb.lt> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40316"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44341@debbugs.gnu.org, Thibault Polge To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 02 13:29:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZYxU-000AOm-6M for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 13:29:12 +0100 Original-Received: from localhost ([::1]:41022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZYxT-0003un-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 07:29:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZYxM-0003ub-C8 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 07:29:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZYxK-0005sm-1m for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 07:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZYxJ-0008OR-Tz for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 07:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2020 12:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44341-submit@debbugs.gnu.org id=B44341.160432010432217 (code B ref 44341); Mon, 02 Nov 2020 12:29:01 +0000 Original-Received: (at 44341) by debbugs.gnu.org; 2 Nov 2020 12:28:24 +0000 Original-Received: from localhost ([127.0.0.1]:40032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZYwi-0008NZ-Bs for submit@debbugs.gnu.org; Mon, 02 Nov 2020 07:28:24 -0500 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:47053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZYwh-0008NL-4s for 44341@debbugs.gnu.org; Mon, 02 Nov 2020 07:28:23 -0500 Original-Received: by mail-oi1-f180.google.com with SMTP id x1so14429225oic.13 for <44341@debbugs.gnu.org>; Mon, 02 Nov 2020 04:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w1oLR60L0yEL30hlEYVQNyonhVftJ2jTBpMPdlmzUHI=; b=USsQ4WnTXOtvZVyrELtnVZi+toWTcbAL1TmOqFMWu66fp59HcGGlj0voVUdsWoXY+b pnFK71w+aM/tp15r0npqs4onh//SUbWylaWPRpi/nIaxqIP3E99wi0h4BcoUtw+vqG0U bzqP+fS6WDutXYA6RSPZDL44lA7x9E/PENDhM8//dVdZkbrAh/xOwOOGx0/9tm7PT7r9 mK6m1tIkIt1PCMqFZ/oUTgASiEWGSysu/nj/IkaE6FFL1BXoOjMHF0aaILr/2ytxRMGg dLTyTmXg9A9tQMaI5WgPcfXvMvrD+tWRhcVuYak2ROB7aB0hGPckuNzQHAD9Ks3JJXkU iwmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w1oLR60L0yEL30hlEYVQNyonhVftJ2jTBpMPdlmzUHI=; b=NU8DzG1VvmqUR4hYHuWztbmYaa8327lFsyk+QyFtULWz4/cr47YPKjN5Rrf5QWxk9p cgKBC2NAePA5lJsCjJzWZCXvmU2LFfVUpLw8MiW0+xPcJRaFLORUuWDIvWS80lhIcLEs eDfvCRaPG9CZC3q/GuCj+f/9e6+oO/SdsOr3oDw0vA5duQJfAvqG4HDOlT+lhDtLpayz IiiEzIoq93EmYSwlBa4LsUlpl6XfAz/+cFI6fvMDGOhXAY1Kd6obN3/uzgGLoHFg0JXw 6Tj52ndtDEH1yZYKZn9hahRWCNQTpvr5Y1ywWuQzIbNGNU5R/1qDiPQAl//KbrtsizAj lGuQ== X-Gm-Message-State: AOAM533myGEYQsw6SZekwk0n7bSSeyupGvBI0CzNeYDicGCn4xnz4AiP FBlOI+EpaLqod+StqhPJGUA0P8lgNfWm9Du6wH8= X-Google-Smtp-Source: ABdhPJzR/gA9ElSTNaAVqJ4Q4Hf+GWKRXo/HyQs7//AND+l5WMlHZ3I89Jv2RPYXmUyUnJAWclGetsWd9Qwoe0QsIL4= X-Received: by 2002:a05:6808:3af:: with SMTP id n15mr2933305oie.65.1604320097367; Mon, 02 Nov 2020 04:28:17 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192510 Archived-At: Am So., 1. Nov. 2020 um 16:30 Uhr schrieb Stefan Monnier : > > disable ; Should disable (as a random symbol) > > disable ; Again > > "What?" ; Same. > > These should be considered as errors. Whether we catch them and signal > an error or silently do something else is not particular important > to me. We should definitely signal an error here. A form such as (my-mode 'enable) actually disabling the mode is very confusing. The mode function needs to check for the various cases anyway, it might as well use `cond' and signal an error in the non-matching case.