bug#28571: 25.3; Compile error on macOS Sierra

[Philipp Stephani <p.stephani2@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

Alan Third <alan@idiocy.org> schrieb am So., 24. Sep. 2017 um 13:07 Uhr:

> On Sun, Sep 24, 2017 at 07:49:55AM +0000, Philipp Stephani wrote:
> > Alan Third <alan@idiocy.org> schrieb am Sa., 23. Sep. 2017 um 21:31 Uhr:
> > >
> > > Is there maybe a test in configure that’s incorrectly identifying this
> > > utimens.c stuff as OK?
> > >
> > >
> > I do have configure output like this:
> >
> > checking for futimens... yes
> > checking for utimensat... yes
> >
> > So I think the functions are there, but the compilation shouldn't use
> them
> > since they would make the binary incompatible with old versions of macOS.
>
> I agree. I’ve attached a patch that should sort it.
>

Thanks, the patch works, but you also need to #undef HAVE_UTIMENSAT.
However, I'm wondering whether that's the right way to solve it. It means
we're making some of the checks manual that have previously been automated,
which implies that we need to recheck in the future whether the checks are
still appropriate etc. Wouldn't it be better to modify configure.ac so that
it doesn't detect these functions as present in the first place if we don't
want to use them?

[-- Attachment #2: Type: text/html, Size: 1643 bytes --]