From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process Date: Wed, 6 May 2020 12:50:18 +0200 Message-ID: References: <871rnyyyio.fsf@gmx.de> <87sggdmp9s.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="119390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41099@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 06 12:51:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWHdw-000Uwp-0k for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 May 2020 12:51:12 +0200 Original-Received: from localhost ([::1]:48466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWHdv-0001ae-24 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 May 2020 06:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWHdm-0001a9-RX for bug-gnu-emacs@gnu.org; Wed, 06 May 2020 06:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWHdm-0003b2-Ia for bug-gnu-emacs@gnu.org; Wed, 06 May 2020 06:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jWHdm-0000nb-Gm for bug-gnu-emacs@gnu.org; Wed, 06 May 2020 06:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 May 2020 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41099 X-GNU-PR-Package: emacs Original-Received: via spool by 41099-submit@debbugs.gnu.org id=B41099.15887622363027 (code B ref 41099); Wed, 06 May 2020 10:51:02 +0000 Original-Received: (at 41099) by debbugs.gnu.org; 6 May 2020 10:50:36 +0000 Original-Received: from localhost ([127.0.0.1]:38655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWHdM-0000mk-0B for submit@debbugs.gnu.org; Wed, 06 May 2020 06:50:36 -0400 Original-Received: from mail-oi1-f169.google.com ([209.85.167.169]:32954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jWHdK-0000mO-RU for 41099@debbugs.gnu.org; Wed, 06 May 2020 06:50:35 -0400 Original-Received: by mail-oi1-f169.google.com with SMTP id o24so1330784oic.0 for <41099@debbugs.gnu.org>; Wed, 06 May 2020 03:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/tUuVolbCP6TD8rRUpQYHh6lvZXI81m6VOoB9da1D0g=; b=R4Tkmr7mhN8yTCSKRC7Mrw6+BGkUqsH++IP0/eiqLVg75XDBO08308dcB6nYPp7ISL jSsBOUERECf0Zlm35IlREY5XnmxAZm9EO2v3KvXvQrYdEM/0ZxtAMUeN7vQ3q52EmM74 pKmq0C74HB3SDtPF52S5w+SyX2J4aZ28BqDqRk7ouzZZCuBH2q4BxzNYZHF6Tz7P7+b7 caMaYkG1JImZH4X5rK/gkrK5tVxhEkXw3mYPhVX4nW7DuXXDDVU/j5STIGzn1ZsMYLWE AWQn5oGsiU0OLuoOjGGnMpzy8ZGWOi8FgJb/EU1werAq7nk1POhE0s5AKb706O1xkbCh duCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/tUuVolbCP6TD8rRUpQYHh6lvZXI81m6VOoB9da1D0g=; b=OFwDDP80DLp1m0OQoY41NLdEfulbtQoqG1wCRlX+t5MIAjpYtqwzF/LyUsHiQtDAJS 06oJIpMFx1MKnZJPFeAlcLQ6gbKE9stzopC726q2MUrbBZv2Dpxkf5zNNRAp4RYBHWYZ l6ZT8Wx5rQ6Zt7UPlq3+RcF3vcnoiwL6+ACkfYxx67yq4IaHdrRDz0f6aSiS21jj2lhM tqaB8Flq08XnjWzv/AY/sMaP2Kho9QgDZVXgD6gqdbIHHid0WU4v0pKm94AlX/+fYSnV RShdN8rh8zhBVxh+FJaCII0huKDwt5uwtYhZQwfBe2h1S/28FQGGIUoSGxV8MCqzVzO/ xBDQ== X-Gm-Message-State: AGi0Pua9k/n9S5cV5NODnxBINnWGI2eEB3xIe5iL2KWTb3+XWpwsuTwu vEKaPafobDgNcHc8p78Qj/GKEdfLk51BXdNnUtc= X-Google-Smtp-Source: APiQypK5izOri6PRkKt13ARQkrkdgvJ3yuFOQ36ydPHdYHWBIbV5HqW6nxb5VQZGWYk8XJcHjR/pgtSZzapzWUYx+gw= X-Received: by 2002:aca:d441:: with SMTP id l62mr2265697oig.9.1588762229098; Wed, 06 May 2020 03:50:29 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179796 Archived-At: Am Mi., 6. Mai 2020 um 12:38 Uhr schrieb Philipp Stephani : > > Am Mi., 6. Mai 2020 um 10:38 Uhr schrieb Michael Albinus > : > > > > Michael Albinus writes: > > > > Hi Philipp, > > > > >> It looks like `tramp-send-command-and-check' should not just search > > >> for the exit code, but also return it. > > > > > > No, most use cases a simple nil or t is appropriate. Otherwise, you would > > > need to check always (zerop (tramp-send-command-and-check ...)). But in > > > tramp-sh-handle-process-file, it shall return the exit code (indicated > > > by an optional argument). > > > > > > Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file. > > > > I've fixed this in master, could you pls check? > > Looks like it's working fine, thanks for the quick fix! As a second step, consider also translating signals: if the exit code is > 128, subtract 128 and return an appropriate string, like call-process does.