all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 41099@debbugs.gnu.org
Subject: bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process
Date: Wed, 6 May 2020 12:50:18 +0200	[thread overview]
Message-ID: <CAArVCkQLYOtVNckufJSmq1rNWPuqM-7arnio594X0oZF_B69jQ@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkTD0DdiNdkvEzL=bYLPw3OwcdPaCMxgHCp89grB-UUBwQ@mail.gmail.com>

Am Mi., 6. Mai 2020 um 12:38 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
> Am Mi., 6. Mai 2020 um 10:38 Uhr schrieb Michael Albinus
> <michael.albinus@gmx.de>:
> >
> > Michael Albinus <michael.albinus@gmx.de> writes:
> >
> > Hi Philipp,
> >
> > >> It looks like `tramp-send-command-and-check' should not just search
> > >> for the exit code, but also return it.
> > >
> > > No, most use cases a simple nil or t is appropriate. Otherwise, you would
> > > need to check always (zerop (tramp-send-command-and-check ...)). But in
> > > tramp-sh-handle-process-file, it shall return the exit code (indicated
> > > by an optional argument).
> > >
> > > Same for tramp-adb-send-command-and-check, called in tramp-adb-handle-process-file.
> >
> > I've fixed this in master, could you pls check?
>
> Looks like it's working fine, thanks for the quick fix!

As a second step, consider also translating signals: if the exit code
is > 128, subtract 128 and return an appropriate string, like
call-process does.





  reply	other threads:[~2020-05-06 10:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 18:49 bug#41099: 28.0.50; TRAMP process-file ignores exit status of remote process Philipp Stephani
2020-05-05 19:02 ` Philipp Stephani
2020-05-05 19:25   ` Michael Albinus
2020-05-06  8:38     ` Michael Albinus
2020-05-06 10:38       ` Philipp Stephani
2020-05-06 10:50         ` Philipp Stephani [this message]
2020-05-06 11:24           ` Michael Albinus
2020-05-06 13:32             ` Michael Albinus
2020-05-06 15:36               ` Philipp Stephani
2020-05-06 17:30                 ` Michael Albinus
2020-05-06 17:56                   ` Philipp Stephani
2020-05-06 17:57                     ` Philipp Stephani
2020-05-06 19:33                       ` Michael Albinus
2020-05-07  8:29                       ` Michael Albinus
2020-05-09 19:53                         ` Philipp Stephani
2020-05-14  1:39                         ` Noam Postavsky
2020-05-14 11:00                           ` Michael Albinus
2020-05-14 12:38                             ` Philipp Stephani
2020-05-14 12:50                               ` Andreas Schwab
2020-05-14 14:07                               ` Noam Postavsky
2020-05-14 14:48                                 ` Philipp Stephani
2020-05-14 15:49                                   ` Michael Albinus
2020-05-16 12:06                                     ` Michael Albinus
2020-05-16 12:11                                     ` Dmitry Gutov
2020-05-16 12:19                                       ` Michael Albinus
2020-05-16 22:03                                         ` Dmitry Gutov
2020-05-17  8:19                                           ` Michael Albinus
2020-05-23 19:17                                         ` Philipp Stephani
2020-05-23 19:35                                           ` Michael Albinus
2020-05-23 19:42                                             ` Philipp Stephani
2020-05-06 17:41                 ` Andreas Schwab
2020-05-06 17:53                   ` Philipp Stephani
2020-05-06 18:58                     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAArVCkQLYOtVNckufJSmq1rNWPuqM-7arnio594X0oZF_B69jQ@mail.gmail.com \
    --to=p.stephani2@gmail.com \
    --cc=41099@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.