Re: make pred customable in auto-save-visited-mode

[Philipp Stephani <p.stephani2@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1822 bytes --]

Philipp Stephani <p.stephani2@gmail.com> schrieb am Sa., 31. März 2018 um
12:23 Uhr:

> Eli Zaretskii <eliz@gnu.org> schrieb am Sa., 31. März 2018 um 10:44 Uhr:
>
>>
>>
>> >   (setq auto-save--timer
>> >         (when auto-save-visited-mode
>> >           (run-with-idle-timer
>> >            auto-save-visited-interval :repeat
>> >            #'save-some-buffers :no-prompt
>> >            (lambda ()  ;;<————————————how about make this customable
>> >              (not (and buffer-auto-save-file-name
>> >                        auto-save-visited-file-name)))))))
>>
>> Letting users customize a non-trivial function is not the best way of
>> affecting this behavior.  I think you can have what you want by adding
>> a function to ediff-startup-hook, and in that function set
>> buffer-auto-save-file-name of the *ediff-merge* buffer to nil.
>>
>>
> I agree that customization isn't the best solution here. However, I'm
> suprised that `save-some-buffers' still prompts even if :noprompt is passed.
> The issue might be in `save-some-buffers': Its docstring says "If PRED is
> t, then certain non-file buffers will also be considered.", but later it
> only checks whether PRED is non-nil:
>
>                     (or
>                      (buffer-file-name buffer)
>                      (with-current-buffer buffer
>                        (or (eq buffer-offer-save 'always)
>                            (and pred buffer-offer-save (> (buffer-size)
> 0)))))
>
> Maybe instead of `pred' here we should say (eq pred t). Alternative, the
> predicate lambda should check whether `buffer-file-name' is non-nil.
>

Probably the second option is better because the first option would prevent
PRED from running for non-file-visiting buffers. Patch attached.

[-- Attachment #1.2: Type: text/html, Size: 2835 bytes --]

[-- Attachment #2: 0001-files.el-auto-save-visited-mode-Don-t-prompt-for-filen.txt --]
[-- Type: text/plain, Size: 1010 bytes --]

From 65efc1bfcfa8a9b14f325df0987bd233ec25edb3 Mon Sep 17 00:00:00 2001
From: Philipp Stephani <phst@google.com>
Date: Sat, 31 Mar 2018 12:26:30 +0200
Subject: [PATCH] * files.el (auto-save-visited-mode): Don't prompt for
 filenames.

---
 lisp/files.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/files.el b/lisp/files.el
index 6a13a9d71a..83cba24336 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -436,8 +436,9 @@ auto-save-visited-mode
            auto-save-visited-interval :repeat
            #'save-some-buffers :no-prompt
            (lambda ()
-             (not (and buffer-auto-save-file-name
-                       auto-save-visited-file-name)))))))
+             (and buffer-file-name
+                  (not (and buffer-auto-save-file-name
+                            auto-save-visited-file-name))))))))
 
 ;; The 'set' part is so we don't get a warning for using this variable
 ;; above, while still catching code that _sets_ the variable to get
-- 
2.16.1