From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: What's the line length limit in the Emacs codebase? Date: Sat, 26 Dec 2020 12:12:03 +0100 Message-ID: References: <83wnx8pm0e.fsf@gnu.org> <20201225203227.GA10689@tuxteam.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21526"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: tomas@tuxteam.de Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 26 12:13:07 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt7VS-0005U7-7j for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 12:13:06 +0100 Original-Received: from localhost ([::1]:58888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kt7VR-00007x-AX for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Dec 2020 06:13:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt7Uf-00088A-Mm for emacs-devel@gnu.org; Sat, 26 Dec 2020 06:12:17 -0500 Original-Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:45054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kt7Ue-0001G2-6p for emacs-devel@gnu.org; Sat, 26 Dec 2020 06:12:17 -0500 Original-Received: by mail-ot1-x335.google.com with SMTP id r9so5330839otk.11 for ; Sat, 26 Dec 2020 03:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EBPfRT1t4EgvtQ7KfmBac0HgdGZFs69WOgVsqDCQZzQ=; b=RcfVYbkHQlJ9ZgVWKfGDYtOXpLZ6uL7fHWZeb8kY/KCf47eASwR77krHPv2azxvjDq UE5KjR7tpIgQWONDtUE6HIBT57K3jANEUJE15DB9W0CCRkbBA9KsWhY7v7YwCpI4LFNG 6+okBMiKZfSjEYhsULPHq94mpTNntQT4Vm7qKxzI36ttp5EGC37lJK/yLgjrCkI3XbYp ZFn7tG2zythuhAnfHI9GdRtQ8QnUnl8Z82UEhvwxTREfAKf0t2gLIJLgE4nu8e8UG64I zk6kcWqJLA9TqlhT12/JQUhqlALToukjnt+76wL0viwNG/eil1LbzJ1IKrJkmTSIeAGX BDyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EBPfRT1t4EgvtQ7KfmBac0HgdGZFs69WOgVsqDCQZzQ=; b=bQno4hQmfGJPps8oYGoEAeyGD2JaKIvESSvbHvweXgoUQ5xSsyJnb1cIy0Krd/FApe uyyZepxdTcnYfEHg3upGe0MRFn6OxuAxZWXZjlR7p/XQPPCJiCFFsMuh1IXfcmDc7yMj AQ/jd1j3BAAnCcOLmCP+hQ63vIGG1VXJWKTMWlZ2asYU8lAxSg5filGZiIvuC+uFAmAJ dz2sn0sg8+XXq8rLDSoVjm5e1AdPQy98mvPg0GWhvnf5sFpLVFv9TbII1NiQlVRfjImu Z1G2YzsRjEWmW6GjVbW7q+p4w6YYBnhUhPy1fDoDfDJXQM9zrqgl3Bt0lQv5GH65vWrs JqVA== X-Gm-Message-State: AOAM5301lXx/xEc1sPOsw/ZI7OMRcYujc7SoUn0b5dWi1iV8LMLkAw4Q VhODu9tKO5yoRY0yn0f0nRANwNlw2t3Cz06QfkIyW/CTNy8= X-Google-Smtp-Source: ABdhPJzAkV9i+qWcaDl3YaCn2YDF1rCWLbAGKIA+IbHBHOtxFK/voJ0IRbr193yxdz0WQ5gXLNEt18CVvgc8qSmjOyw= X-Received: by 2002:a05:6830:3106:: with SMTP id b6mr26432836ots.36.1608981134775; Sat, 26 Dec 2020 03:12:14 -0800 (PST) In-Reply-To: <20201225203227.GA10689@tuxteam.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::335; envelope-from=p.stephani2@gmail.com; helo=mail-ot1-x335.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261837 Archived-At: Am Fr., 25. Dez. 2020 um 23:01 Uhr schrieb : > > On Fri, Dec 25, 2020 at 06:11:57PM +0100, Philipp Stephani wrote: > > [...] > > > This seems overly complicated, and people are unlikely to follow > > complicated rules. > > I tend to disagree. > > > Let's just pick a number and stick to it consistently. > > That doesn't make much sense, IMO. Most of the time it's > easy to stick to the recommended 70. More often than not, > it even helps to nudge oneself into structuring code > better. Then why don't we just do that (for new code)? Why do we need two limits? > > But sometimes (e.g. you have long string literals where > breaks don't make sense -- but there are other examples), > it is rather counterproductive to stick religiously to > that rule. I'm not talking about such special cases, but about normal code or comment blocks that could easily be reflowed. > Honestly, I perceive Stefan's criteria as pretty natural. I don't.