From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Introduce new misc type for module function Date: Sun, 23 Apr 2017 15:34:39 +0000 Message-ID: References: <20170422160553.63385-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0d7e823432fc054dd73b09 X-Trace: blaine.gmane.org 1492961706 14931 195.159.176.226 (23 Apr 2017 15:35:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Apr 2017 15:35:06 +0000 (UTC) Cc: Philipp Stephani , Emacs development discussions To: =?UTF-8?Q?Aur=C3=A9lien_Aptel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 23 17:35:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2JXP-0003fQ-Gs for ged-emacs-devel@m.gmane.org; Sun, 23 Apr 2017 17:34:59 +0200 Original-Received: from localhost ([::1]:39588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2JXS-0008S0-4o for ged-emacs-devel@m.gmane.org; Sun, 23 Apr 2017 11:35:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2JXJ-0008Ru-Uc for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:34:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2JXJ-00031k-3O for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:34:53 -0400 Original-Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:38850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2JXI-00031a-RY for emacs-devel@gnu.org; Sun, 23 Apr 2017 11:34:53 -0400 Original-Received: by mail-wm0-x232.google.com with SMTP id r190so49480317wme.1 for ; Sun, 23 Apr 2017 08:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6CGWXGOy9fpVxVQ4Fr8E4tB2Ee67qkJVCXNjRn8p9cM=; b=Gt6bEfEOKhQBbsutjLNHkYDrvFlSdMVdT2wE9FJnS6fTEWarSXvS/n99jSmEIEvh2v ZHWpsrAZ5t3UmAEoKfXV16WZzwF5VxNF6LxmiXpAgQo0f9AI7NTsRRgl3zKtI575maPs JCUppZLUA3So9rJmhVmmoeEoInf+f4d4iaihUPJf/bcOdpBhTCbmxUiIpvGBT3JkC4k8 5kSchCRog9SBbyqDD7rWT1BbZjCyhbqfoUCDAa1dJXz4LoWh0Bi4yBu/NIBX/K10Foh0 MEGrhjmlMcboMjM7k3M+kALXmYkP53j7dGJcH8zxZ8gb3EnKFmeNSBoNlOKe1BKa/FI7 wS1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6CGWXGOy9fpVxVQ4Fr8E4tB2Ee67qkJVCXNjRn8p9cM=; b=I8lNnG/ZqcM8JkSTkb2LPmc79z4P/Pr2XNb13klEMn+CigqnO8ZzntJy0xqglsLoEd +4nkijekKwzUR4agMGjsDoBDCbYtAkXw1DOFIK+3bw+xPrH+98WeCYYsTWGNP7r0Ux0i XLDSMPXyi7+Z4keJoSaSURksXjT/IfgoOkgWoaNWr6QTNmkFi9/NXLBnhRPXSyfoRNZ3 dAaLgWncO/fNnrGpJnb14zKobBp7bdz1o7YTz0ol9Bjg2iqnNSfYY45dtfdogm8bioEt Ms2ZFsWJw2KTnnUJAs1yJCtID9beJieShILesGs5/st0Cie8R3xgddVbL96tEGSNAeEi gRVQ== X-Gm-Message-State: AN3rC/7kVhm5ppQLg702/2u2IkB69auHBxaMeno8S6yFm3tLrjF0PWCO zNeHM5aYxzmofEbo9Pj/dlmCvsLWRA== X-Received: by 10.28.199.76 with SMTP id x73mr6499275wmf.95.1492961690135; Sun, 23 Apr 2017 08:34:50 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214243 Archived-At: --94eb2c0d7e823432fc054dd73b09 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Aur=C3=A9lien Aptel schrieb am So., 23. Ap= r. 2017 um 17:19 Uhr: > Hi Philipp, > > Nice to see you work on modules :) > > * Shouldn't we try to map module function to subr instead of adding > another type? > Eventually yes, but I'd prefer to do that later and introduce the misc subtype now to get rid of the most pressing problems associated with using the save pointer (probably wrong type, no garbage collection). Turning module functions into proper subrs is a bit more involved since all pieces of code that touch subrs need to be adapted. > * Should we get rid of make_global_ref? It serves no purpose anymore > IIUC since you can't reuse emacs_values between module function calls. > My understanding is that the emacs_value objects returned from make_global_ref should be usable across environments and threads; at least that's my understanding of both the desired and the implemented behavior. --94eb2c0d7e823432fc054dd73b09 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Aur=C3= =A9lien Aptel <aurel= ien.aptel+emacs@gmail.com> schrieb am So., 23. Apr. 2017 um 17:19=C2= =A0Uhr:
Hi Philipp,

Nice to see you work on modules :)

* Shouldn't we try to map module function to subr instead of adding
another type?

Eventually yes, but I'= ;d prefer to do that later and introduce the misc subtype now to get rid of= the most pressing problems associated with using the save pointer (probabl= y wrong type, no garbage collection). Turning module functions into proper = subrs is a bit more involved since all pieces of code that touch subrs need= to be adapted.
=C2=A0
* Should we get rid of make_global_ref? It serves no purpose anymore
IIUC since you can't reuse emacs_values between module function calls.<= br>

My understanding is that the emacs_valu= e objects returned from make_global_ref should be usable across environment= s and threads; at least that's my understanding of both the desired and= the implemented behavior.=C2=A0
--94eb2c0d7e823432fc054dd73b09--