From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24372@debbugs.gnu.org
Subject: bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point
Date: Sat, 01 Oct 2016 16:11:05 +0000 [thread overview]
Message-ID: <CAArVCkQAdr=90UBCK=XYR3a954Lr4b7fcaoiky7ZuJeZe-qUXw@mail.gmail.com> (raw)
In-Reply-To: <831t00mq6w.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2727 bytes --]
Eli Zaretskii <eliz@gnu.org> schrieb am Sa., 1. Okt. 2016 um 10:25 Uhr:
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Sun, 25 Sep 2016 19:09:52 +0000
> > Cc: 24372@debbugs.gnu.org
> >
> > > How about a variant of this below? It uses a fixed limitation from
> > > below on the delay, but only for the first blink. (The value 0.2 was
> > > found by experimentation, not sure if we need to add yet another
> > > defcustom for that.)
> > >
> > > I don't think we should introduce magic numbers or further
> customization options.
> >
> > It solves the problem, doesn't it? I don't mind very much if it were
> > a defcustom, I just think no one would want to change it.
> >
> > OK, then it would be great to document the new behavior in the
> documentation of `blink-cursor-delay' and also
> > clarify what "starting to blink" means.
>
> Done.
>
Thanks!
>
> > > > I've attached another patch with the change I have in mind.
> > >
> > > This has a disadvantage of creating a new timer object each time,
> > > which I think we'd like to avoid: too much consing. (Also, don't you
> > > need to set the timer variable to nil when the timer is disabled?)
> > >
> > > I don't understand - the patch doesn't create any additional timers,
> it only changes the initial delay of
> > the
> > > idle-timer.
> >
> > Each time blink-cursor--start-timer or blink-cursor--start-idle-timer
> > is called, they create a new timer, right? And your patch makes us
> > call these functions each time blinking is started or ended, right?
> >
> > No, the other patch is that it restarts the timers when the
> customization options are set. Otherwise the options
> > only become effective after a focus-out/focus-in event or something
> similar that restarts the cursor.
> >
> > > My patch is identical, except is uses blink-cursor-interval as lower
> bound.
> >
> > Of course. That's why I said it's a minor variant.
> >
> > There's another difference, though: in my patch we only limit the
> > first argument to run-with-timer/run-with-idle-timer, not the second.
> > So only the first blink cycle is affected.
> >
> > Doesn't that mean that the adjusted delay is applied only after the
> first command, but not after subsequent
> > commands?
>
> No, not AFAIK. The idle time starts anew after each command.
>
Indeed, the repeat argument of run-with-idle-timer is only checked for
nil-ness and otherwise ignored. I'd suggest to pass something like :repeat
or t to that argument so that readers are less confused.
>
> Is there anything left to do about this, or can we close this bug?
>
>
The second patch (restarting the timers after the customization options
changed) is still open, what about that one?
[-- Attachment #2: Type: text/html, Size: 4778 bytes --]
next prev parent reply other threads:[~2016-10-01 16:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 19:16 bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point Philipp Stephani
2016-09-05 21:29 ` Clément Pit--Claudel
2016-09-06 16:03 ` Eli Zaretskii
2016-09-09 15:59 ` Philipp Stephani
2016-09-09 16:07 ` Eli Zaretskii
2016-09-09 16:20 ` Philipp Stephani
2016-09-09 16:29 ` Philipp Stephani
2016-09-09 17:18 ` Philipp Stephani
2016-09-09 18:59 ` Philipp Stephani
2016-09-10 7:21 ` Eli Zaretskii
2016-09-11 9:15 ` Philipp Stephani
2016-09-11 16:23 ` Eli Zaretskii
2016-09-11 17:37 ` Philipp Stephani
2016-09-11 19:18 ` Eli Zaretskii
2016-09-23 14:28 ` Eli Zaretskii
2016-09-25 19:09 ` Philipp Stephani
2016-10-01 8:25 ` Eli Zaretskii
2016-10-01 16:11 ` Philipp Stephani [this message]
2016-10-01 17:29 ` Eli Zaretskii
2016-10-01 18:10 ` Philipp Stephani
2016-10-02 7:12 ` Eli Zaretskii
2016-10-01 18:16 ` Philipp Stephani
2016-10-02 7:14 ` Eli Zaretskii
2016-10-02 17:56 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkQAdr=90UBCK=XYR3a954Lr4b7fcaoiky7ZuJeZe-qUXw@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=24372@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.