From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Philipp Stephani <phst@google.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Fri, 19 Apr 2019 21:06:48 +0200 [thread overview]
Message-ID: <CAArVCkQ8v7jKOkrX8mWWTQYOMmcmsAVzANZifvkbormNCxrtWQ@mail.gmail.com> (raw)
In-Reply-To: <CAArVCkQsvEuPyFmuVSaopok5AWJXd7mAhCN_gVk-PKr5VHaokw@mail.gmail.com>
Am So., 24. Feb. 2019 um 22:51 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
> Am Mi., 13. Feb. 2019 um 16:29 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
> >
> > > From: Philipp Stephani <p.stephani2@gmail.com>
> > > Cc: Philipp Stephani <phst@google.com>
> > > Date: Mon, 11 Feb 2019 21:17:39 +0100
> > >
> > > pending_signals is often set if no quit is pending. This results in
> > > bugs in module code if the module returns but no quit is actually
> > > pending.
> > >
> > > As a better alternative, add a new process_input environment function
> > > for Emacs 27. That function processes signals (like maybe_quit).
> >
> > Thanks, this LGTM.
>
> Thanks, pushed as 72ec233f2a.
Question: Would it be OK to backport the first part (using QUITP in
module_should_quit) to Emacs 26.3? Right now should_quit behaves
erratically: it occasionally quits, but in other instances doesn't
because pending_signals has been reset in the meantime.
next prev parent reply other threads:[~2019-04-19 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 21:22 [PATCH] Ignore pending_signals when checking for quits Philipp Stephani
2019-01-03 14:03 ` Eli Zaretskii
2019-02-10 18:49 ` Philipp Stephani
2019-02-10 19:40 ` Eli Zaretskii
2019-02-10 19:46 ` Philipp Stephani
2019-02-10 20:15 ` Eli Zaretskii
2019-02-11 20:17 ` Philipp Stephani
2019-02-13 15:28 ` Eli Zaretskii
2019-02-24 21:51 ` Philipp Stephani
2019-04-19 19:06 ` Philipp Stephani [this message]
2019-04-19 20:15 ` Eli Zaretskii
2019-04-28 18:19 ` Philipp Stephani
2019-04-28 18:42 ` Eli Zaretskii
2019-08-07 16:22 ` Philipp Stephani
2019-01-03 14:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkQ8v7jKOkrX8mWWTQYOMmcmsAVzANZifvkbormNCxrtWQ@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.