From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: 27bb4de72b * Port cleanup attribute to Oracle Studio 12.5 Date: Wed, 14 Jun 2017 10:29:49 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1136f5c8c4976c0551e908cb" X-Trace: blaine.gmane.org 1497436252 5986 195.159.176.226 (14 Jun 2017 10:30:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Jun 2017 10:30:52 +0000 (UTC) To: Paul Eggert , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 14 12:30:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dL5ZW-0001HX-P5 for ged-emacs-devel@m.gmane.org; Wed, 14 Jun 2017 12:30:46 +0200 Original-Received: from localhost ([::1]:47665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dL5ZZ-0008Tf-6L for ged-emacs-devel@m.gmane.org; Wed, 14 Jun 2017 06:30:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dL5Yn-0008Rq-Co for emacs-devel@gnu.org; Wed, 14 Jun 2017 06:30:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dL5Ym-0004Sa-MC for emacs-devel@gnu.org; Wed, 14 Jun 2017 06:30:01 -0400 Original-Received: from mail-ot0-x22e.google.com ([2607:f8b0:4003:c0f::22e]:36261) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dL5Ym-0004RB-Ht for emacs-devel@gnu.org; Wed, 14 Jun 2017 06:30:00 -0400 Original-Received: by mail-ot0-x22e.google.com with SMTP id s7so14056779otb.3 for ; Wed, 14 Jun 2017 03:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=aUg1qFRYJLZXOHV39VXjDo8x07Byd30hEmuaaVXotpA=; b=HE0nuTvlpjZJbUd2sJ+TnrloshHB5RGBjWdZME8YBtfLb8FhRWq4QdzkKrXADbM7tM a8r5ahCuFi98H3mbNPqhftrX1yPoZdC9ViTwb/6ph9P32VaVh1R1u+7efZKUtR3KS/1c EkiZ9bvuA4g1nBrLLsDdxadweSALoQ9dkYrAhUl2f9+ZegPrsTFcpmyP0LMiwmlcHh+Q Sd5kuWvFyrO/eqr41A0b64LKoCEWfvqT4F3LMThhpPltGYJxORZmSUJ62p4Jb3cidCsj qiA5nsRo0ATmCb/tliuhhcYBRidmmuwYg3f9KgACHTdX3osWgu7+o4/VEdGQnv1UeKeE VS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=aUg1qFRYJLZXOHV39VXjDo8x07Byd30hEmuaaVXotpA=; b=iY7SLII6tlbegmXAloxY8fRtNioGNhBcTinrLbWPRet4miOAcUg7SZe0zxKS6BRlnZ lXGTU31gjUWUUpRDkaoNfbWyKiDjx2xzSugT5Gorl+jiFM1azUSrqnE4z3tQXG/Apy67 KvqdFlPWH6to3LtSnVbDoOf5jt86RP5VJ1a85eQh228exYKa25jO9ktJTaOS7hH7gDAw vsiV1M379logjYh3cXGry6MRgc/5l88VoejS70IY0CylvActSnyhiAXyiwvYtZk2r0Ij xtLFIY2c80Pih4mduXclddOsJGGi0Dz/Q/G77XdijnBy6mVSrtMId9eGMJPolLSHftKR jF6Q== X-Gm-Message-State: AKS2vOzCvJwA+CMdfTjKhGlPf9hGk2wYmp3SmsNc7tPq/pXa9xCz6zyv PL912yjGY3K/7ioBEQQSW6qTXj7iOxh5 X-Received: by 10.157.30.129 with SMTP id n1mr2479644otn.243.1497436199883; Wed, 14 Jun 2017 03:29:59 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215613 Archived-At: --001a1136f5c8c4976c0551e908cb Content-Type: text/plain; charset="UTF-8" Hi, the commit message says "The C compiler should check the cleanup attribute in the next line anyway." But that's not the case: unknown attributes are silently ignored, at least in Clang. The verify(__has_attribute(cleanup)) or equivalent is absolutely required here. Can we revert that commit? --001a1136f5c8c4976c0551e908cb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

the commit message says "The C= compiler should check the cleanup attribute in the next line anyway."= But that's not the case: unknown attributes are silently ignored, at l= east in Clang. The verify(__has_attribute(cleanup)) or equivalent is absolu= tely required here. Can we revert that commit?
--001a1136f5c8c4976c0551e908cb--