From mboxrd@z Thu Jan 1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Philipp Stephani
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH 0/5] Add systemd socket launching support.
Date: Sun, 27 Mar 2016 17:21:31 +0000
Message-ID:
References: <1459027002-13215-1-git-send-email-matthew@mattleach.net>
<83mvpkynzd.fsf@gnu.org> <87fuvcosq5.fsf@mattleach.net>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary=001a11c3690288415a052f0b072d
X-Trace: ger.gmane.org 1459099324 23851 80.91.229.3 (27 Mar 2016 17:22:04 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sun, 27 Mar 2016 17:22:04 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Matthew Leach , Eli Zaretskii
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 27 19:22:00 2016
Return-path:
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
by plane.gmane.org with esmtp (Exim 4.69)
(envelope-from )
id 1akENy-0003Su-1s
for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 19:21:58 +0200
Original-Received: from localhost ([::1]:36782 helo=lists.gnu.org)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from )
id 1akENx-0004LM-5M
for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 13:21:57 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52679)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1akENj-0004L7-5M
for emacs-devel@gnu.org; Sun, 27 Mar 2016 13:21:44 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1akENi-0004vS-4c
for emacs-devel@gnu.org; Sun, 27 Mar 2016 13:21:43 -0400
Original-Received: from mail-lb0-x22b.google.com ([2a00:1450:4010:c04::22b]:36700)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from )
id 1akENh-0004vN-SW; Sun, 27 Mar 2016 13:21:42 -0400
Original-Received: by mail-lb0-x22b.google.com with SMTP id qe11so70515945lbc.3;
Sun, 27 Mar 2016 10:21:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=Ki12S30HIjLX1Vj9CLTFUlRmSUZN+a4VEGNpWDw7OVU=;
b=e1kVh1R2kzdvFAAdzBF8fvJDfvC0fWg7TDF5Jui8+kpHtLCE5c981lEAvru5XCzbJD
4C7VlVnQfz7B/xzYe5yTnaQUr3AFLI0b3948GsTuj32BvoD1pkJ16ZIPAHu1mG1GYxfT
AX79wh9cayQPeepHta/lZCRRXUO+oa5PnT8jvYcnxClxqnfwmeqJ27PDxlTQhhWKGUBI
AXi852EIxuvTNiSvSGnbG64EMqhHK5Lf7BqL+pkvpb7Y26Aua5YFC2lKcg3XGbLXzSNt
NjfrlHRR19WpGuc42LmMKQJxj5cIIyrSed2255QA9L+8VKPQYEYEvcT2EuVmKQefKuDH
mfHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=Ki12S30HIjLX1Vj9CLTFUlRmSUZN+a4VEGNpWDw7OVU=;
b=Lu+8tKOajsKrIZyrADRWnDkPPgA0DsHL3vM7Oz/7k+dfr8StcNoTcHZebgCFGpo1ks
nwsDyJtyTKR4wuR79ZH8fZpAsfZZvidQrnwh1LPUnbPJf3B2HtwdbiufyavBAP1z3E/r
NVwW4MkzyNPy28K+K1FN10qFwtuvDJNUCYy1tMNSDgv0YXtQ0L4rFW61imRnocrIiyuU
GEc8b6kqQ5Grt64+62AA/9POUBQQVA48bvVJ3lq6t0fqKnb2jDHR4/DnXqvVOtfolzCl
efwsL0+WtmIvRvDy9IsE9x/nKTqrsRj+sT/Nme8mkwwoXJUl8LfoYM1DI9lblqYSPGA8
QCGQ==
X-Gm-Message-State: AD7BkJJez6ub8ShZVN2uGceLQhFpTqu/vIRw+YvtV1gCjAiZ/b9GOczOVk+ax4jbQ5hv5hDUTlrdsXLsbBpRtQ==
X-Received: by 10.112.126.233 with SMTP id nb9mr8687606lbb.74.1459099301066;
Sun, 27 Mar 2016 10:21:41 -0700 (PDT)
In-Reply-To: <87fuvcosq5.fsf@mattleach.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:4010:c04::22b
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions."
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:202298
Archived-At:
--001a11c3690288415a052f0b072d
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Matthew Leach schrieb am So., 27. M=C3=A4rz 2016 um
17:17 Uhr:
> >> +#ifdef HAVE_SYSTEMD
> >> + /* Read the number of sockets passed through by systemd. */
> >> + systemd_socket =3D sd_listen_fds(0);
> >
> > Isn't it prudent to test the socket descriptor for validity? What if
> > it isn't a socket, for example?
>
> Agreed. I'm thinking about trying getsockname as a test for validity as
> this should also ensure that the socket is already bound.
>
The systemd library has some helper functions for that:
https://www.freedesktop.org/software/systemd/man/sd_is_fifo.html
--001a11c3690288415a052f0b072d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
>> +#ifdef HAVE_SYSTEMD
>> +=C2=A0 =C2=A0 =C2=A0 /* Read the number of sockets passed through=
by systemd. */
>> +=C2=A0 =C2=A0 =C2=A0 systemd_socket =3D sd_listen_fds(0);
>
> Isn't it prudent to test the socket descriptor for validity?=C2=A0=
What if
> it isn't a socket, for example?
Agreed.=C2=A0 I'm thinking about trying getsockname as a test for valid=
ity as
this should also ensure that the socket is already bound.
<=
div>
--001a11c3690288415a052f0b072d--