Potential bug in Image mode on Emacs 29 PGTK on Wayland

Potential bug in Image mode on Emacs 29 PGTK on Wayland

[Soham Gumaste]

Hello,

I think I have come across a potential bug -- On emacs 29 PGTK, .ppm
files dont render `image-toggle-display` is called. I was just
experimenting with different versions of emacs, and the non-pgtk build
for emacs29 does NOT have this issue.

Steps to repro:
0. Use emacs 29 PGTK on a Wayland desktop environment
1. C-x C-f a file that is of the .ppm format (Portable Pixmap Format)
2. C-c C-c to view the image
3. Nothing happens.

I can, however, "fix" this "bug" by setting
`inhibit-eval-elisp-during-redisplay` to `t`, but that also breaks a
bunch of other stuff. Please let me know how I can document this
further, or if it is an issue on my end.

My configs are as follows:
Emacs config: https://github.com/SohamG/dotfiles/blob/main/.emacs.d/configuration.org
Emacs package: `emacs29-pgtk` as found in NixPkgs 23.11

Please include me as To: and/or Cc: as I consume this mailing list via
the digests option of mailman.

Thanks

-- 
Soham Gumaste
sohamg2@gmail.com

Re: Potential bug in Image mode on Emacs 29 PGTK on Wayland

[Eli Zaretskii]

> From: Soham Gumaste <sohamg2@gmail.com>
> Date: Thu, 7 Mar 2024 16:45:32 -0600
> 
> I think I have come across a potential bug -- On emacs 29 PGTK, .ppm
> files dont render `image-toggle-display` is called. I was just
> experimenting with different versions of emacs, and the non-pgtk build
> for emacs29 does NOT have this issue.
> 
> Steps to repro:
> 0. Use emacs 29 PGTK on a Wayland desktop environment
> 1. C-x C-f a file that is of the .ppm format (Portable Pixmap Format)
> 2. C-c C-c to view the image
> 3. Nothing happens.
> 
> I can, however, "fix" this "bug" by setting
> `inhibit-eval-elisp-during-redisplay` to `t`, but that also breaks a
> bunch of other stuff. Please let me know how I can document this
> further, or if it is an issue on my end.
> 
> My configs are as follows:
> Emacs config: https://github.com/SohamG/dotfiles/blob/main/.emacs.d/configuration.org
> Emacs package: `emacs29-pgtk` as found in NixPkgs 23.11

Why is your config important here? doesn't the problem happen in
"emacs -Q"?

Re: Potential bug in Image mode on Emacs 29 PGTK on Wayland

[Soham Gumaste]

> Why is your config important here? doesn't the problem happen in
> "emacs -Q"?

Hey, thanks for the reply. I'm sorry I forgot to mention in the
original email that this does NOT happen with `emacs -Q`. That is to
say everything works as expected in `emacs -Q`. I have gone through my
config, and ran the debugger on `image-toggle-display-image` and I
can't find anything particular in my config that could be related.


-- 
Soham Gumaste
sohamg2@gmail.com

Re: Potential bug in Image mode on Emacs 29 PGTK on Wayland

[Eli Zaretskii]

> From: Soham Gumaste <sohamg2@gmail.com>
> Date: Fri, 8 Mar 2024 10:39:06 -0600
> Cc: emacs-devel@gnu.org
> 
> > Why is your config important here? doesn't the problem happen in
> > "emacs -Q"?
> 
> Hey, thanks for the reply. I'm sorry I forgot to mention in the
> original email that this does NOT happen with `emacs -Q`. That is to
> say everything works as expected in `emacs -Q`. I have gone through my
> config, and ran the debugger on `image-toggle-display-image` and I
> can't find anything particular in my config that could be related.

Well, that's a very large configuration that loads a lot of packages.
I think you need to enable them one by one, or do a bisection, until
you find the customization that causes the problem.  It is not
reasonable to expect someone else here to do this work for you.

Re: Potential bug in Image mode on Emacs 29 PGTK on Wayland

[Soham Gumaste]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

On Fri, Mar 8, 2024 at 10:53 AM Eli Zaretskii <eliz@gnu.org> wrote:

>  It is not
> reasonable to expect someone else here to do this work for you.
>
I'm sorry I wasn't clear - asking that wasn't my intention. What I was
wondering is if given the same config, a feature (ie display ppm images)
working on emacs but not on emacs-pgtk counts as a bug or regression.

[-- Attachment #2: Type: text/html, Size: 690 bytes --]

Re: Potential bug in Image mode on Emacs 29 PGTK on Wayland

[Eli Zaretskii]

> From: Soham Gumaste <sohamg2@gmail.com>
> Date: Fri, 8 Mar 2024 11:07:22 -0600
> Cc: emacs-devel@gnu.org
> 
> On Fri, Mar 8, 2024 at 10:53 AM Eli Zaretskii <eliz@gnu.org> wrote:
> 
>   It is not
>  reasonable to expect someone else here to do this work for you.
> 
> I'm sorry I wasn't clear - asking that wasn't my intention. What I was wondering is if given the same config, a
> feature (ie display ppm images) working on emacs but not on emacs-pgtk counts as a bug or regression. 

We cannot answer that question unless we understand what causes the
problem.

Re: Potential bug in Image mode on Emacs 29 PGTK on Wayland

[Eli Zaretskii]

> From: Soham Gumaste <sohamg2@gmail.com>
> Date: Fri, 8 Mar 2024 10:45:58 -0600
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> > Is it possible that the ppm file itself plays a role? Some work, some don't?
> 
> Thanks for the reply.
> 
> I am attaching my PPM file to this email (assuming mailman lets me).

This file is 6MB.  Please in the future don't post such files
uncompressed, if at all.  It is better to post a link where people who
want can download it.