From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Geoffrey Ferrari Newsgroups: gmane.emacs.bugs Subject: bug#33394: 27.0.50; trampver cannot determine repository version Date: Thu, 15 Nov 2018 13:10:53 +0000 Message-ID: References: <87tvkifu1q.fsf@gmx.de> <8736s2fqi2.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000826616057ab3c851" X-Trace: blaine.gmane.org 1542287411 26399 195.159.176.226 (15 Nov 2018 13:10:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2018 13:10:11 +0000 (UTC) Cc: 33394@debbugs.gnu.org To: michael.albinus@gmx.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 15 14:10:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNHPI-0006eE-Nz for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2018 14:10:04 +0100 Original-Received: from localhost ([::1]:38735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNHRO-00066t-Pb for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2018 08:12:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNHRI-00066m-ER for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 08:12:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNHRC-0000XX-Kc for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 08:12:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gNHRC-0000XQ-HP for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 08:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gNHRC-0000vX-BC for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2018 08:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Geoffrey Ferrari Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Nov 2018 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 33394-submit@debbugs.gnu.org id=B33394.15422874733497 (code B ref 33394); Thu, 15 Nov 2018 13:12:02 +0000 Original-Received: (at 33394) by debbugs.gnu.org; 15 Nov 2018 13:11:13 +0000 Original-Received: from localhost ([127.0.0.1]:53107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNHQP-0000uL-0T for submit@debbugs.gnu.org; Thu, 15 Nov 2018 08:11:13 -0500 Original-Received: from mail-vs1-f44.google.com ([209.85.217.44]:42919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNHQN-0000u8-1z for 33394@debbugs.gnu.org; Thu, 15 Nov 2018 08:11:11 -0500 Original-Received: by mail-vs1-f44.google.com with SMTP id b74so11612483vsd.9 for <33394@debbugs.gnu.org>; Thu, 15 Nov 2018 05:11:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w2gO8dmfR4HXeZh0X4DGf1Q/k+I6v3FfF73sWShpWA8=; b=Du0UtwpcLqlLjAuujTuOu10kweEhIYYkP/3Zd1hGbFveMSO5r2ZP6NhhEFqSVkzKx5 BEp2e8y8SgQ695A6CEynISsFyS3hcrpZ7tSvHIA8QqkXqO3Dk+AsljlXBV/NtzgqhUpX x7ELaQC76ziTUOSL2Z6bmCaU/vCjc/LxmMS47styAp1Edan7lxMn3j3sOyThAg2159X9 XhWXQOfwAb41lAq4NG4v4KhiRFX6d8JGQG8VxYHdlpfbQg4yg7X6LkpftdZrvutNCrjH 9hdclIj8PDw8C+cIIoh1hE6npmSAk8QPm0+8x2zWThDvKUw9EeOuqU2myfVwnE1sZh5o XfRQ== X-Gm-Message-State: AGRZ1gJdSNhzqfjb2QCpnzj9DS7QXDB8FL0UA8cYZHoHDsGVYoZKaoJj z0VG8kmMpey/VYCx+IPr3qMwyNL2PmihkbMVFiA= X-Google-Smtp-Source: AJdET5fnm/F+dXFu4PuGeg/UzLBOQYCl0Edhjc40a9iY75ge+DaqotJyB2YS+9kk+U2BUS6F717H1mGOzAqiGxXnhOg= X-Received: by 2002:a67:4a96:: with SMTP id e22mr2534401vsg.92.1542287465275; Thu, 15 Nov 2018 05:11:05 -0800 (PST) In-Reply-To: <8736s2fqi2.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152416 Archived-At: --000000000000826616057ab3c851 Content-Type: text/plain; charset="UTF-8" Thanks, Michael. I no longer get an error message with the new version of trampver, so this seems to have fix it. Of course, the two constants tramp-repository-branch and tramp-repository-version now both have the value nil on an end user system, but I assume that's both acceptable and intended. Kind regards, Geoff On Thu, 15 Nov 2018 at 12:57, Michael Albinus wrote: > Geoffrey Ferrari writes: > > Hi Geoffrey, > > > Thanks Michael. On further investigation, I've found that this minimal > > code (after starting with emacs -Q) produces the same unexpected > > error: > > > > (condition-case nil > > (emacs-repository-get-branch nil) > > (error nil)) > > You're right. After setting `default-directory' and `source-directory' > to "/not/existing" I see the same error. `call-process' seems to break > the `condition-case' jail. > > > I don't think I can investigate further as condition-case is not a > > lisp function. > > I've hardened trampver.el, committed to the master branch. Could you, > pls, check? > > > Kind regards > > > > Geoff > > Best regards, Michael. > --000000000000826616057ab3c851 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, Michael.
I no longer get an error message with the new version of trampv= er, so this seems to have fix it. Of course, the two constants=C2=A0tramp-r= epository-branch and=C2=A0tramp-repository-version now both have the value = nil on an end user system, but I assume that's both acceptable and inte= nded.

Kind regards,

Geoff=

On = Thu, 15 Nov 2018 at 12:57, Michael Albinus <michael.albinus@gmx.de> wrote:
Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org> wri= tes:

Hi Geoffrey,

> Thanks Michael. On further investigation, I've found that this min= imal
> code (after starting with emacs -Q) produces the same unexpected
> error:
>
> (condition-case nil
> (emacs-repository-get-branch nil)
>=C2=A0 =C2=A0(error nil))

You're right. After setting `default-directory' and `source-directo= ry'
to "/not/existing" I see the same error. `call-process' seems= to break
the `condition-case' jail.

> I don't think I can investigate further as condition-case is not a=
> lisp function.

I've hardened trampver.el, committed to the master branch. Could you, pls, check?

> Kind regards
>
> Geoff

Best regards, Michael.
--000000000000826616057ab3c851--