From: Jonathan Kyle Mitchell <kyle@jonathanmitchell.org>
To: rudalics@gmx.at
Cc: 31968@debbugs.gnu.org, Robert Pluim <rpluim@gmail.com>,
Carlos Pita <carlosjosepita@gmail.com>
Subject: bug#31968: 26.1.50; Allow to hide title bar on maximize (gtk/gnome/csd)
Date: Sat, 30 Jun 2018 17:32:16 -0500 [thread overview]
Message-ID: <CAAnK0TZDeX82pAw1GkMqVhK97t05++0PXg=HyK6Q8NUa7K=E4A@mail.gmail.com> (raw)
In-Reply-To: <5B374075.50300@gmx.at>
On Sat, Jun 30, 2018 at 3:38 AM martin rudalics <rudalics@gmx.at> wrote:
>
> > That would be a somewhat bigger patch. Iʼm assuming weʼd need to
> > adjust nsgui and w32gui frame parameter definitions as well.
>
> For non-GTK builds we'd have to proceed as follows:
>
> (1) When we do the maximization ourselves, remove the decorations
> first and then maximize.
>
> (2) When we get a maximize event, remove the decorations.
>
> (3) For any event or action that removes the maximized state, re-add
> the decorations provided the frame should not stay undecorated via
> a frame parameter.
>
> So this would require some quite substantial coding effort and should
> definitely wait until someone confirms that your GTK patch works.
>
> martin
I had the opportunity to test Robert's C patch on a recent copy of the
master branch today in a Fedora 28 VM using Gnome3, Xfce4, and KDE5.
Setting the hide argument to `t' in the new Lisp function
`x-set-hide-titlebar-when-maximized' worked as expected in Gnome and
Xfce--the titlebar disappeared when I maximized the Emacs frame. The
KDE titlebar remained in place except when putting Emacs in fullscreen
mode.
--
Jonathan Kyle Mitchell
next prev parent reply other threads:[~2018-06-30 22:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 20:43 bug#31968: 26.1.50; Allow to hide title bar on maximize (gtk/gnome/csd) Carlos Pita
2018-06-27 10:07 ` Robert Pluim
2018-06-27 13:02 ` Carlos Pita
2018-06-27 13:25 ` Robert Pluim
2018-06-27 15:20 ` Carlos Pita
2018-06-28 4:22 ` Jonathan Kyle Mitchell
2018-06-28 8:02 ` martin rudalics
2018-06-28 12:23 ` Robert Pluim
2018-06-28 8:02 ` martin rudalics
2018-06-28 15:25 ` Robert Pluim
2018-06-29 8:42 ` martin rudalics
2018-06-29 8:48 ` Robert Pluim
2018-06-30 8:33 ` martin rudalics
2018-06-30 22:32 ` Jonathan Kyle Mitchell [this message]
2018-06-30 22:54 ` Carlos Pita
2018-06-30 23:25 ` Carlos Pita
2018-07-01 0:13 ` Carlos Pita
2018-07-01 9:04 ` martin rudalics
2018-07-01 17:23 ` Carlos Pita
2018-07-01 17:35 ` Carlos Pita
2018-07-01 17:46 ` Carlos Pita
2018-07-01 18:08 ` Carlos Pita
2018-07-02 13:24 ` Robert Pluim
2018-07-02 14:28 ` Carlos Pita
2018-07-02 17:44 ` Carlos Pita
2018-07-02 20:03 ` Robert Pluim
2018-07-02 22:29 ` Carlos Pita
2018-07-03 2:06 ` Carlos Pita
2018-07-03 2:09 ` Carlos Pita
2018-07-03 23:35 ` Carlos Pita
2018-07-02 9:13 ` martin rudalics
2018-07-02 13:21 ` Robert Pluim
2018-07-01 9:02 ` martin rudalics
2018-07-02 13:31 ` Robert Pluim
2018-07-02 14:22 ` Carlos Pita
2018-07-01 9:02 ` martin rudalics
2018-07-02 5:06 ` Jonathan Kyle Mitchell
2020-09-04 4:15 ` Lars Ingebrigtsen
2022-04-28 12:03 ` Lars Ingebrigtsen
2022-04-29 4:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 10:03 ` Lars Ingebrigtsen
2022-04-29 10:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 10:31 ` Lars Ingebrigtsen
2022-04-29 10:42 ` Lars Ingebrigtsen
2022-04-29 17:11 ` Juri Linkov
2022-04-29 18:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAnK0TZDeX82pAw1GkMqVhK97t05++0PXg=HyK6Q8NUa7K=E4A@mail.gmail.com' \
--to=kyle@jonathanmitchell.org \
--cc=31968@debbugs.gnu.org \
--cc=carlosjosepita@gmail.com \
--cc=rpluim@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.