From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Hassard Newsgroups: gmane.emacs.bugs Subject: bug#17971: 24.3.92; Patch to fix el compression on RHEL/CentOS 7 Date: Tue, 8 Jul 2014 08:50:52 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e013cb9ae7045be04fdb08edb X-Trace: ger.gmane.org 1404834753 1860 80.91.229.3 (8 Jul 2014 15:52:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Jul 2014 15:52:33 +0000 (UTC) Cc: 17971@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 08 17:52:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X4Xgq-0007pj-CU for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Jul 2014 17:52:20 +0200 Original-Received: from localhost ([::1]:56359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Xgq-0000xb-1K for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Jul 2014 11:52:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4Xgf-0000uG-1w for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 11:52:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4XgZ-00053w-Dd for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 11:52:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4XgZ-00053r-91 for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 11:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X4XgY-0007sU-FK for bug-gnu-emacs@gnu.org; Tue, 08 Jul 2014 11:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Hassard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jul 2014 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17971-submit@debbugs.gnu.org id=B17971.140483466330192 (code B ref 17971); Tue, 08 Jul 2014 15:52:02 +0000 Original-Received: (at 17971) by debbugs.gnu.org; 8 Jul 2014 15:51:03 +0000 Original-Received: from localhost ([127.0.0.1]:47165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4XfZ-0007qt-Rm for submit@debbugs.gnu.org; Tue, 08 Jul 2014 11:51:02 -0400 Original-Received: from mail-oa0-f53.google.com ([209.85.219.53]:56682) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4XfW-0007qI-Hd for 17971@debbugs.gnu.org; Tue, 08 Jul 2014 11:50:59 -0400 Original-Received: by mail-oa0-f53.google.com with SMTP id l6so6619954oag.40 for <17971@debbugs.gnu.org>; Tue, 08 Jul 2014 08:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hassard.net; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rN4uUjUTS4I2Z43rz77cwWn11a2FtVwXU0GmtV6Tiag=; b=REY2iGlpLxJEV4slUTsXsihCOCfChq1NDNpmnl6n0ly4ARn+hGbOUoz89ok6s8Wpom GZbTNWPv+NDfmAwyX5+R4zkJBCr4s1vG/42ZJHypUHvjueIeVQmCovxR0PVcXFN5F97L rGx6zD9zGeS9CJz9a+ERpLRBZHBFcoDzQ/e1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=rN4uUjUTS4I2Z43rz77cwWn11a2FtVwXU0GmtV6Tiag=; b=EDnzjSRZx7m3mRCgLXv7MfPmAtZrApP4gXDvJtWkaJVd368/Ioxgleo5y/02l8WZSF b+t4TPQpkqUQfJQV+AP68zpUZ7OxNsM681pq2IAMu7m2AKHVxhu1L6uQutpoSvSxWYWy 9tq575j6harPzAHGemAJ3szmfnn7IDwtr7pqt3PdkJ2tVxB0PFrHLH3FPT3y9zSR62x1 WTdJrFaF6GM6z/27ycDR6ldAAhKxVmAhMIllBWntozCl0s+N8fdtUf3BTyJ0mki0fkth HaD2k3sKiZTruhBsuJpcPOPstAVPZcyr0E23g2UgpCXwNmx5Za7JGkPZS7eEPtlm6FCn x7oA== X-Gm-Message-State: ALoCoQlIdE5CGt/17N2tFTm9onhz8eJiz3CF9xyw0yTod8OGV8Ddl53aah2Gh1rbZV4YvMPhqLKQ X-Received: by 10.182.87.9 with SMTP id t9mr3512098obz.72.1404834652627; Tue, 08 Jul 2014 08:50:52 -0700 (PDT) Original-Received: by 10.76.114.71 with HTTP; Tue, 8 Jul 2014 08:50:52 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91315 Archived-At: --089e013cb9ae7045be04fdb08edb Content-Type: multipart/alternative; boundary=089e013cb9ae7045b904fdb08ed9 --089e013cb9ae7045b904fdb08ed9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Here's the relevant output from the 'make install' on CentOS 7: ---- [ -z "/usr/bin/gzip" ] || { \ echo "Compressing *.el ..." && \ cd "/home/shassard/opt/emacs/share/emacs/24.3.92/lisp" && \ find . -name '*.elc' -exec /bin/sh -c \ '/usr/bin/gzip -9n `expr "$1" : "\\(.*\\)c"`' dummy '{}' ';'; \ } Compressing *.el ... find: =E2=80=98./progmodes/make-mode.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/m4-mode.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/cc-fonts.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/cc-engine.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/idlw-complete-structtag.el=E2=80=99: No such fil= e or directory find: =E2=80=98./progmodes/meta-mode.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/bat-mode.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/gud.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/simula.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/autoconf.el=E2=80=99: No such file or directory find: =E2=80=98./progmodes/prog-mode.el=E2=80=99: No such file or directory ---- make immediately fails after this point. I've attached a revised patch that adds the -9n flag to the gzip command and switch back to -exec for find. On Mon, Jul 7, 2014 at 11:04 PM, Glenn Morris wrote: > Stephen Hassard wrote: > > > The current alpha builds are failing during 'make install' while > > performing the .elc compression on CentOS 7. > > Please tell us how it fails. > > > I've cleaned up the find command in the Makefile and have a patch that > > fixes the problem while retaining function on Ubuntu/Debian. Please fin= d > > it attached. > > Sadly I don't think -execdir is portable. > --089e013cb9ae7045b904fdb08ed9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Here's the relevant output from the 'mak= e install' on CentOS 7:

----
[ -z "/usr/bin/gzip" ]= || { \
=C2=A0 echo "Compressing *.el ..." && \
=C2= =A0 cd "/home/shassard/opt/emacs/share/emacs/24.3.92/lisp" &&= amp; \
=C2=A0 find . -name '*.elc' -exec /bin/sh -c \
=C2=A0=C2=A0=C2= =A0 '/usr/bin/gzip -9n `expr "$1" : "\\(.*\\)c"`= 9; dummy '{}' ';'; \
}
Compressing *.el ...
find: = =E2=80=98./progmodes/make-mode.el=E2=80=99: No such file or directory
find: =E2=80=98./progmodes/m4-mode.el=E2=80=99: No such file or directoryfind: =E2=80=98./progmodes/cc-fonts.el=E2=80=99: No such file or director= y
find: =E2=80=98./progmodes/cc-engine.el=E2=80=99: No such file or dire= ctory
find: =E2=80=98./progmodes/idlw-complete-structtag.el=E2=80=99: No= such file or directory
find: =E2=80=98./progmodes/meta-mode.el=E2=80=99: No such file or directory=
find: =E2=80=98./progmodes/bat-mode.el=E2=80=99: No such file or direct= ory
find: =E2=80=98./progmodes/gud.el=E2=80=99: No such file or director= y
find: =E2=80=98./progmodes/simula.el=E2=80=99: No such file or directo= ry
find: =E2=80=98./progmodes/autoconf.el=E2=80=99: No such file or directory<= br>find: =E2=80=98./progmodes/prog-mode.el=E2=80=99: No such file or direct= ory
----

make immediately fails after this point.

I've attached a revised patch that adds the -9n flag to the gzip co= mmand and switch back to -exec for find.


On Mon,= Jul 7, 2014 at 11:04 PM, Glenn Morris <rgm@gnu.org> wrote:
Stephen Hassard wrote:

> The current alpha builds are failing during 'make install' whi= le
> performing the .elc compression on CentOS 7.

Please tell us how it fails.

> I've cleaned up the find command in the Makefile and have a patch = that
> fixes the problem while retaining function on Ubuntu/Debian. Please fi= nd
> it attached.

Sadly I don't think -execdir is portable.

--089e013cb9ae7045b904fdb08ed9-- --089e013cb9ae7045be04fdb08edb Content-Type: text/x-diff; charset=US-ASCII; name="0001-Fix-.el-compression-on-CentOS-7.patch" Content-Disposition: attachment; filename="0001-Fix-.el-compression-on-CentOS-7.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hxdeblhd0 RnJvbSA1MGMwMTYyZWM0ZmQyMmE3NTdkZjY5ZmFiZTgyMDI2ODUwOTNjYTc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVwaGVuIEhhc3NhcmQgPHN0ZXZlQGhhc3NhcmQubmV0PgpE YXRlOiBUdWUsIDggSnVsIDIwMTQgMDg6NDY6NTQgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXgg LmVsIGNvbXByZXNzaW9uIG9uIENlbnRPUyA3CgotLS0KIE1ha2VmaWxlLmluIHwgNSArKy0tLQog MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9NYWtlZmlsZS5pbiBiL01ha2VmaWxlLmluCmluZGV4IDc2YTAzMDQuLmY0ZmQ0YWEgMTAw NjQ0Ci0tLSBhL01ha2VmaWxlLmluCisrKyBiL01ha2VmaWxlLmluCkBAIC02MTQsOSArNjE0LDgg QEAgaW5zdGFsbC1hcmNoLWluZGVwOiBsaXNwIGluc3RhbGwtaW5mbyBpbnN0YWxsLW1hbiAke0lO U1RBTExfQVJDSF9JTkRFUF9FWFRSQX0KIAkgICR7d3JpdGVfc3ViZGlyfSB8fCB0cnVlCiAJWyAt eiAiJHtHWklQX1BST0d9IiBdIHx8IHsgXAogCSAgZWNobyAiQ29tcHJlc3NpbmcgKi5lbCAuLi4i ICYmIFwKLQkgIGNkICIkKERFU1RESVIpJHtsaXNwZGlyfSIgJiYgXAotCSAgZmluZCAuIC1uYW1l ICcqLmVsYycgLWV4ZWMgJChTSEVMTCkgLWMgXAotCSAgICAnJHtHWklQX1BST0d9IC05biBgZXhw ciAiJCQxIiA6ICJcXCguKlxcKWMiYCcgZHVtbXkgJ3t9JyAnOyc7IFwKKyAgICAgICAgICBmaW5k ICIkKERFU1RESVIpJHtsaXNwZGlyfSIgLW5hbWUgJyouZWwnIFwKKyAgICAgICAgICAgIC1leGVj ICR7U0hFTEx9IC1jICd0ZXN0IC1mIHt9YycgXDsgLWV4ZWMgJHtHWklQX1BST0d9IC05biB7fSBc OyA7IFwKIAl9CiAJLWNobW9kIC1SIGErciAiJChERVNURElSKSR7ZGF0YWRpcn0vZW1hY3MvJHt2 ZXJzaW9ufSIgJHtDT1BZREVTVFN9CiAKLS0gCjEuOC4zLjEKCg== --089e013cb9ae7045be04fdb08edb--