From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Braun =?UTF-8?Q?G=C3=A1bor?= Newsgroups: gmane.emacs.bugs Subject: bug#34405: 26.1; patch for cancel-change-group to work after undo Date: Fri, 15 Nov 2019 00:00:23 +0100 Message-ID: References: <1631063.cd5q6Ms6ql@gabor> <3538177.LDI8N28pS7@gabor> <835zjm7j5n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000fd59590597567265" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50527"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34405@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 00:03:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVO94-000D3C-Et for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 00:03:22 +0100 Original-Received: from localhost ([::1]:34392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVO93-0002Vn-AN for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 18:03:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34632) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVO6p-0001Hl-SS for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 18:01:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVO6o-00011Z-TT for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 18:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVO6o-00011P-4p for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 18:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVO6n-0007Zo-U8 for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 18:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Braun =?UTF-8?Q?G=C3=A1bor?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2019 23:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34405 X-GNU-PR-Package: emacs Original-Received: via spool by 34405-submit@debbugs.gnu.org id=B34405.157377244429094 (code B ref 34405); Thu, 14 Nov 2019 23:01:01 +0000 Original-Received: (at 34405) by debbugs.gnu.org; 14 Nov 2019 23:00:44 +0000 Original-Received: from localhost ([127.0.0.1]:35396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVO6V-0007ZC-IW for submit@debbugs.gnu.org; Thu, 14 Nov 2019 18:00:43 -0500 Original-Received: from mail-yb1-f171.google.com ([209.85.219.171]:43330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVO6T-0007Yv-Do for 34405@debbugs.gnu.org; Thu, 14 Nov 2019 18:00:41 -0500 Original-Received: by mail-yb1-f171.google.com with SMTP id r201so3273902ybc.10 for <34405@debbugs.gnu.org>; Thu, 14 Nov 2019 15:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K1R7AUUBEThhlUDHhXv52rWKaYFe4x0aZIlLutNk4lQ=; b=E+6PUXdyWyNGFiNeug80/tC8oVMlkTAkUpC9pYZNY1KnnarMa3hHKe9Va1zXQ8gDV4 hXZOmumaOGoWJo/3iXzrsqfuV6uMjT0XMppi002y6AoG+UXiJCLkePpEXOdnLkm3NZWY U3mAQUQiAOT3SF3lCMGF6XwSRf0VYP15GtcFUYY5nJXWaPmc3nE0+ppTOldMSFJqZVwR 6hErTWMA7gu1ZqzNidXH8iEgqznkI3nohR+hwghcod5lIYbs1EAX2Vu6x2145ykpPgmr r/UZiqeX7K6RjHtURditdSaZQ915PgX4RhEyPL9J5YMcJcOZGxOvTaajiiycgicxvScJ 67Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K1R7AUUBEThhlUDHhXv52rWKaYFe4x0aZIlLutNk4lQ=; b=gNKCztwgqAmn6XEqAcDjYy6p3DLW6Vrsx6AOe2BERPtgE3Fja3DlA5x0f7cbF7PzEl pX3mrtxn+Ty4rmPJwnCmPlGfcZAeCyWQtrnjiw+8PxZi+BxH2udpfP6ufEfWJUfbHGxh +ne6pCXSEpQn9V5VTc87+Nx7ipmY7ZKBP4NB4XZOxbQXXYDBI1+kyCV7w4TlQlzn3u2+ /CC+vuvc5BNh5sf9Fc41hJYiW/Kc/2JWsmM9i9fu5uoH2T3Tw3ExnwzEbWUmFTrTox8t 0cEiB2LF6oInj4QdjOz3XD7SOMyZyYOCjMpFuGdZX4W0Mid9wF2WgDwOEXjYj76eQCOl sotg== X-Gm-Message-State: APjAAAXjX/EKjm1AMKzYfsGig5CtsQdlh3DaMSCNaQwRk+vs13Qdkz+T jK40DsKkiSJ6FDg1ciqcx5jadYpT/m51/y5tOn8= X-Google-Smtp-Source: APXvYqzjtZ8+7ffvIrxM3KdIQnhzkphDqXQ85beWDXweKLjqRF4VPp07nJ2UDEpbVvdCV8fyQts/iosrc+0S5mcCXSk= X-Received: by 2002:a25:a326:: with SMTP id d35mr9623348ybi.224.1573772435739; Thu, 14 Nov 2019 15:00:35 -0800 (PST) In-Reply-To: <835zjm7j5n.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171620 Archived-At: --000000000000fd59590597567265 Content-Type: text/plain; charset="UTF-8" > > > Please consider the following fix to the problem, patching function > > cancel-change-group. > > Thanks. > > If this problem could be solved locally in the atomic groups code, I'd > prefer that. The patch is local to the atomic groups code: it only changes the function cancel-change-group, whose purpose is to abort an atomic group. If not, then let's postpone changes in the low-level > undo machinery There is no intention to change there anything. I'd like to > avoid adding more changes in such deep innards. > That is perfectly understandable. > --000000000000fd59590597567265 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Please consider the following fix to the problem, patching funct= ion
> cancel-change-group.

Thanks.

If this problem could be solved locally in the atomic groups code, I'd<= br> prefer that.

The patch is local to the atomic groups code: it only changes
the function cancel-change-group, whose purpose is to a= bort an atomic group.

=C2=A0 If not, then= let's postpone changes in the low-level
undo machinery

There is no intention to change there anything.

=C2=A0I'd like to
avoid adding more changes in such deep innards.

That is perfectly understand= able.
--000000000000fd59590597567265--