Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.

Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.

[Stefan Monnier]

> +	 ((if (memq system-type '(windows-nt ms-dos))
> +	      (string-match "\\`[a-zA-Z]:\\|[\\][^\\]" ido-selected)
> +	    (string-match "/[^/]" ido-selected))

Aka

   	 ((string-match (if (memq system-type '(windows-nt ms-dos))
   	                    "\\`[a-zA-Z]:\\|[\\][^\\]"
   	                  "/[^/]")
                        ido-selected)

-- Stefan

Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.

[Leo Liu]

On 2013-06-24 11:19 +0800, Stefan Monnier wrote:
> Aka
>
>    	 ((string-match (if (memq system-type '(windows-nt ms-dos))
>    	                    "\\`[a-zA-Z]:\\|[\\][^\\]"
>    	                  "/[^/]")
>                         ido-selected)
>
> -- Stefan

Fixed.

Leo

Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.

[Juanma Barranquero]

On Mon, Jun 24, 2013 at 6:17 AM, Leo Liu <sdl.web@gmail.com> wrote:

>>        ((string-match (if (memq system-type '(windows-nt ms-dos))
>>                           "\\`[a-zA-Z]:\\|[\\][^\\]"
>>                         "/[^/]")
>>                         ido-selected)

Aka   ((string-match-p ...)) as it is used as a predicate, and not to
extract match data.

   J

Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.

[Eli Zaretskii]

> From: Leo Liu <sdl.web@gmail.com>
> Date: Mon, 24 Jun 2013 12:17:50 +0800
> Cc: emacs-devel@gnu.org
> 
> On 2013-06-24 11:19 +0800, Stefan Monnier wrote:
> > Aka
> >
> >    	 ((string-match (if (memq system-type '(windows-nt ms-dos))
> >    	                    "\\`[a-zA-Z]:\\|[\\][^\\]"
> >    	                  "/[^/]")
> >                         ido-selected)
> >
> > -- Stefan
> 
> Fixed.

Why doesn't this support forward slashes on DOS/Windows?  It should.

string-match-p [was Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.]

[Glenn Morris]

Juanma Barranquero wrote:

> Aka   ((string-match-p ...)) as it is used as a predicate, and not to
> extract match data.

If I don't care about the match data one way or the other (as here, I
assume) why is string-match-p preferable? Is it faster or something?

Re: string-match-p [was Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.]

[Juanma Barranquero]

On Mon, Jun 24, 2013 at 6:12 PM, Glenn Morris <rgm@gnu.org> wrote:

> If I don't care about the match data one way or the other (as here, I
> assume) why is string-match-p preferable? Is it faster or something?

If we consider (as we do) that save-match-data is expensive enough
that we only do when necessary, I'd assume not registering the match
data is faster than registering it, yes.

But anyway, the main reason is legibility. If you encounter
string-match-p or looking-at-p you can be confident that they are
being used as predicates and the following code does not depend on the
match data. That is a net gain IMO.

   J

Re: string-match-p [was Re: [Emacs-diffs] trunk r113149: * ido.el (ido-read-internal): Fix bug#14620.]

[Leo Liu]

On 2013-06-25 00:16 +0800, Juanma Barranquero wrote:
> But anyway, the main reason is legibility. If you encounter
> string-match-p or looking-at-p you can be confident that they are
> being used as predicates and the following code does not depend on the
> match data. That is a net gain IMO.

I agree but since ido.el is written without this in mind I will leave it
as is to be consistent with adjacent code.

Leo