From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Juanma Barranquero <lekktu@gmail.com>
Newsgroups: gmane.emacs.bugs
Subject: bug#16677: 24.3.50; Wrong type argument: char-or-string-p, 67108923
Date: Fri, 7 Feb 2014 04:55:04 +0100
Message-ID: <CAAeL0STsVYYLN+AVaGkA-NAcV5WKyHevGrcdMjBntVWC5Oy=Eg@mail.gmail.com>
References: <2ba9d857-f8b1-4f0b-8640-41229d998838@default>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Trace: ger.gmane.org 1391745370 10746 80.91.229.3 (7 Feb 2014 03:56:10 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 7 Feb 2014 03:56:10 +0000 (UTC)
Cc: 16677@debbugs.gnu.org
To: Drew Adams <drew.adams@oracle.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 07 04:56:17 2014
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1WBcY5-0005rz-1U
	for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Feb 2014 04:56:17 +0100
Original-Received: from localhost ([::1]:39556 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1WBcY4-0005he-Nm
	for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Feb 2014 22:56:16 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBcXx-0005hQ-28
	for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2014 22:56:13 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBcXr-0004hq-GD
	for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2014 22:56:09 -0500
Original-Received: from debbugs.gnu.org ([140.186.70.43]:40017)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBcXr-0004hm-Cl
	for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2014 22:56:03 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1WBcXq-0006GE-BO
	for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2014 22:56:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Juanma Barranquero <lekktu@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Fri, 07 Feb 2014 03:56:01 +0000
Resent-Message-ID: <handler.16677.B16677.139174534924049@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 16677
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
Original-Received: via spool by 16677-submit@debbugs.gnu.org id=B16677.139174534924049
	(code B ref 16677); Fri, 07 Feb 2014 03:56:01 +0000
Original-Received: (at 16677) by debbugs.gnu.org; 7 Feb 2014 03:55:49 +0000
Original-Received: from localhost ([127.0.0.1]:54036 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1WBcXb-0006Fn-S2
	for submit@debbugs.gnu.org; Thu, 06 Feb 2014 22:55:48 -0500
Original-Received: from mail-ea0-f180.google.com ([209.85.215.180]:57747)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <lekktu@gmail.com>) id 1WBcXZ-0006Fe-DQ
	for 16677@debbugs.gnu.org; Thu, 06 Feb 2014 22:55:46 -0500
Original-Received: by mail-ea0-f180.google.com with SMTP id o10so1288324eaj.11
	for <16677@debbugs.gnu.org>; Thu, 06 Feb 2014 19:55:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; 
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type;
	bh=U0mOd3E05zcgoJbdi/jvhnam+Iv9BjPtjh10d3TF3ho=;
	b=CaqGIuDpiDHNal6/N4hf50NA0egkgrqQq5cZiQJBzJfobFeJs7DXJ9BmPee+qCVlCp
	/4yenP1ysqm2xuN/kM3ri1k3C0aIJle6Pwdq5I82BesMWAj1/kHT28vFu5v2c7+Xba3p
	UIE3ZbYGLc0YX4RSoDxUFgpVSwnyD42YkI8P7Ki/8aBhv0sFXAK5DfdMhp9jALLoO4QB
	AgTLggX7V1HTOZM50t/n6rzljQGHd3g+fv9mtjlaGDZAr1RxZGkrg1ISC9GIfrx7HSR5
	6/dXQwgFVQjbB2VpaPpxU2MYZ7HZgQDDyXVHiKdtIXp1I+0LkjdUGFKuJNnz+A4sLdyg
	4kfA==
X-Received: by 10.14.177.1 with SMTP id c1mr13622098eem.8.1391745344424; Thu,
	06 Feb 2014 19:55:44 -0800 (PST)
Original-Received: by 10.14.128.133 with HTTP; Thu, 6 Feb 2014 19:55:04 -0800 (PST)
In-Reply-To: <2ba9d857-f8b1-4f0b-8640-41229d998838@default>
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 140.186.70.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
	the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.bugs:84786
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/84786>

On Fri, Feb 7, 2014 at 3:57 AM, Drew Adams <drew.adams@oracle.com> wrote:

> Emacs 23 got it right, but it did not make the extra effort to give the
> user an error message that s?he deserves: something more helpful than a
> low-level barf message (even if that message might be comprehensible to
> a knowledgable Emacs user).

It's not just an UI issue. If you type that in a buffer with binary
overwrite mode enabled, quoted-insert will delete a char and then
barf.

So I'd suggest this:

=== modified file 'lisp/simple.el'
--- lisp/simple.el 2014-02-07 03:22:34 +0000
+++ lisp/simple.el 2014-02-07 03:54:27 +0000
@@ -739,4 +739,7 @@
     ;;          (<= char ?\377))
     ;;     (setq char (unibyte-char-to-multibyte char)))
+    (unless (characterp char)
+      (user-error "%s is not a character"
+                  (help-key-description (vector char) nil)))
     (if (> arg 0)
  (if (eq overwrite-mode 'overwrite-mode-binary)