From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Wrong pointer comparison in w32fns.c Date: Sun, 30 Oct 2022 00:36:20 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000070f9605ec34030f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24188"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 30 00:37:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oouSY-00069G-2c for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Oct 2022 00:37:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oouRr-0001gl-1X; Sat, 29 Oct 2022 18:37:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oouRp-0001gc-5b for emacs-devel@gnu.org; Sat, 29 Oct 2022 18:37:01 -0400 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oouRn-00010v-Hz for emacs-devel@gnu.org; Sat, 29 Oct 2022 18:37:00 -0400 Original-Received: by mail-ej1-x62e.google.com with SMTP id f27so21018900eje.1 for ; Sat, 29 Oct 2022 15:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=+41Tz7L6MaU+9R4jnVRSiUJ7mt9wI9aFmpGUy7LOHgk=; b=L8urodR/Jo8yPtUE0ePaUx2AO3jqRILb2d0c8Ao9k/xih8SHDYSOkybMvnPZilTuaR aiz3uGitg8yWnCAJmY/7O+z391uWcLQg889oCbfIqSOBLLvj4Q2bO/d50AaEGixckSrw bmI5Lpckb/G9akxuQh8L88p1xAEO4XfRmVATt0qU4SllmoGCP1sakrKDbPfR+0Zr0kxr pmhkYTiV9jULPUy1xEXDmFBR4q4N90VTBhl/thfTc/5uDRYIt1hd3cosW0/uPXYgKEUU lFr0E4GTIQvQaU+n7+A9ZzvNDg3sLZzU+jtb0vVQl3wYBsdYTev1ld78baesLCQeFL6m y32A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+41Tz7L6MaU+9R4jnVRSiUJ7mt9wI9aFmpGUy7LOHgk=; b=eZXn1zUb4NuEawOtNfwbITH80HQUHXjUg+P1trTSR/p9V/WkQTtNsiDhP7SUtJCueD +Ofa4SfvqBYPdJPVadlifcTz4BLI1xidKTvhs8im7n11BMZe+8cnhzZD1aGUvkQ62Yju KpOSO9TAyGQTSk/hR6gbrt0rHKCAFO3/iwhkfAZD6FxHuoyW90LqS4czsDjGr3CrcOMS FlczUtaKD9FAP+erzu2HD+lB8otXUut6OkuoMh7TMv6Kq4LZz2Cb3ARfK4bqzypmrLg3 BGzoBE/88SFUJTYQmIUaaDTa3eXc82iVlYJ8ac5vvK+IY83XtL9fxIpyceHzaMjuww5w LVuQ== X-Gm-Message-State: ACrzQf10Xg4xOtEfUic9N+EasNCRVJSqv9XiuCy7MMMFd346ePWQqRjL unJme9ayZHl43cukrDPL0Re42yH3W0XLiEPb0Bf3wcWpn78= X-Google-Smtp-Source: AMsMyM6I/hMSY4K9mB27M/LWL+HWEoB7HK5AlXukY+i2fyE1T1do6PBPTIceCQHw5RkhjvbPEh36SitP+7XLjRO2cso= X-Received: by 2002:a17:907:2bd9:b0:7ad:c301:a799 with SMTP id gv25-20020a1709072bd900b007adc301a799mr711424ejc.713.1667083016800; Sat, 29 Oct 2022 15:36:56 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=lekktu@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298783 Archived-At: --000000000000070f9605ec34030f Content-Type: text/plain; charset="UTF-8" Presumably, this is a bug in rarely used code (affecting NT 4 systems): CC w32fns.o w32fns.c: In function 'setup_w32_kbdhook': w32fns.c:2738:24: warning: the comparison will always evaluate as 'true' for the address of 'newTitle' will never be NULL [-Waddress] 2738 | if (newTitle != NULL) | ^~ w32fns.c:2733:19: note: 'newTitle' declared here 2733 | wchar_t newTitle[64]; | ^~~~~~~~ requiring something like this: diff --git i/src/w32fns.c w/src/w32fns.c index 5f652ae9e4..46c73f762a 100644 --- i/src/w32fns.c +++ w/src/w32fns.c @@ -2734,8 +2734,7 @@ setup_w32_kbdhook (void) int i; CoCreateGuid (&guid); - StringFromGUID2 (&guid, newTitle, 64); - if (newTitle != NULL) + if (StringFromGUID2 (&guid, newTitle, 64) && newTitle[0]) { GetConsoleTitleW (oldTitle, 1024); SetConsoleTitleW (newTitle); --000000000000070f9605ec34030f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Presumably, this is a bug in rarely used code (affecting N= T 4 systems):

=C2=A0 CC =C2=A0 =C2=A0 =C2=A0 w32fns.o
w32fns.c: I= n function 'setup_w32_kbdhook':
w32fns.c:2738:24: warning: the c= omparison will always evaluate as 'true' for the address of 'ne= wTitle' will never be NULL [-Waddress]
=C2=A02738 | =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 if (newTitle !=3D NULL)
=C2=A0 =C2=A0 =C2=A0 | =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0^~
w32fns.c:2733:19: note: 'newTitle' declared here
=C2= =A02733 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 wchar_t newTitle[64];
=C2= =A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 ^~~~~~~~

requiring something like this:

diff --git i/= src/w32fns.c w/src/w32fns.c
index 5f652ae9e4..46c73f762a 100644
--- i= /src/w32fns.c
+++ w/src/w32fns.c
@@ -2734,8 +2734,7 @@ setup_w32_kbdh= ook (void)
=C2=A0 =C2=A0int i;
=C2=A0
=C2=A0 =C2=A0CoCreateGuid = (&guid);
- =C2=A0StringFromGUID2 (&guid, newTitle, 64);
- = =C2=A0if (newTitle !=3D NULL)
+ =C2=A0if (StringFromGUID2 (&guid, n= ewTitle, 64) && newTitle[0])
=C2=A0 =C2=A0 =C2=A0{
=C2=A0 = =C2=A0 =C2=A0 =C2=A0GetConsoleTitleW (oldTitle, 1024);
=C2=A0 =C2=A0 = =C2=A0 =C2=A0SetConsoleTitleW (newTitle);

--000000000000070f9605ec34030f--