From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#21930: emacs-repository-get-version fails on linked worktrees Date: Tue, 17 Nov 2015 01:20:15 +0100 Message-ID: References: <867flha6qv.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113fc40ac6ffb60524b17f11 X-Trace: ger.gmane.org 1447722899 9504 80.91.229.3 (17 Nov 2015 01:14:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2015 01:14:59 +0000 (UTC) Cc: 21930@debbugs.gnu.org To: Stephen Leake Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 17 02:14:51 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZyUr5-0005LD-JU for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Nov 2015 02:14:43 +0100 Original-Received: from localhost ([::1]:54414 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyUr5-0003w6-5H for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Nov 2015 20:14:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyU1C-0001WR-0X for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 19:21:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyU18-0003lA-Ra for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 19:21:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyU18-0003l5-Nz for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 19:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZyU18-0007yd-DU for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 19:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2015 00:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21930 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21930-submit@debbugs.gnu.org id=B21930.144771965830639 (code B ref 21930); Tue, 17 Nov 2015 00:21:02 +0000 Original-Received: (at 21930) by debbugs.gnu.org; 17 Nov 2015 00:20:58 +0000 Original-Received: from localhost ([127.0.0.1]:40634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyU14-0007y6-0d for submit@debbugs.gnu.org; Mon, 16 Nov 2015 19:20:58 -0500 Original-Received: from mail-lf0-f46.google.com ([209.85.215.46]:35341) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyU12-0007xx-1v for 21930@debbugs.gnu.org; Mon, 16 Nov 2015 19:20:56 -0500 Original-Received: by lfdo63 with SMTP id o63so96726459lfd.2 for <21930@debbugs.gnu.org>; Mon, 16 Nov 2015 16:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Yx6jnjNRZXFdKHHA99XxCzRnhaCwuoDgHmgFWhAxVWI=; b=ghln/GkVSpCkAMvJsgJU+3kH5xcEZComdq9jiado4IqjlVxpOkvmcjNbVLOSYT6Utr iB/phtOIBM0EFcuQXtLKmfAIc1WSo3UdFEa/ZFSCKKD4mcNmMclx8PbCRFGah5Bt15Ld wC0l2KnGNudl2UTO/U58kDuplerdtHajbKekrLwMeoLgvWw2LVVFJSfBaPK/o3BENtIO JDqIwBold2AKIZwuk7Ot20YfihT/BADIQFIzF2jvH41FgpRvQBxABNKzxzjHCsq+hmSO UEZQJc9ohd1nkrIypiWKg8G71vemNC7UlT2cT1y2bWT8fnHgFRstmvE7ea0/mLoYlq+g REEQ== X-Received: by 10.25.135.136 with SMTP id j130mr18156061lfd.95.1447719655110; Mon, 16 Nov 2015 16:20:55 -0800 (PST) Original-Received: by 10.25.21.198 with HTTP; Mon, 16 Nov 2015 16:20:15 -0800 (PST) In-Reply-To: <867flha6qv.fsf@stephe-leake.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108802 Archived-At: --001a113fc40ac6ffb60524b17f11 Content-Type: text/plain; charset=UTF-8 On Tue, Nov 17, 2015 at 12:01 AM, Stephen Leake < stephen_leake@stephe-leake.org> wrote: > I'm guessing because running any background process doesn't work during > dumping; they don't work in general in batch mode. The code refers to bug#20799, which states that git (and other external processes) cannot be run while dumping because `exec-path' is nil. So the function, to be usable on a linked worktree while dumping, needs to directly read the .git file. That's what my patch does. Calls to `emacs-repository-get-version' with EXTERNAL = t already work (when not dumping) without my patch, of course. > Looks good to me. Great. --001a113fc40ac6ffb60524b17f11 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable --001a113fc40ac6ffb60524b17f11--