From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Fixing some warnings in emacs-26 Date: Sun, 9 Jun 2019 13:02:18 +0200 Message-ID: References: <83wohwo3xw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="190839"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Andreas Schwab , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 09 13:04:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZvcm-000nTQ-F0 for ged-emacs-devel@m.gmane.org; Sun, 09 Jun 2019 13:04:32 +0200 Original-Received: from localhost ([::1]:34886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZvck-0007Ig-Gh for ged-emacs-devel@m.gmane.org; Sun, 09 Jun 2019 07:04:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52551) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZvbU-0007Gx-Ok for emacs-devel@gnu.org; Sun, 09 Jun 2019 07:03:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZvbT-0004Y2-LS for emacs-devel@gnu.org; Sun, 09 Jun 2019 07:03:12 -0400 Original-Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]:43700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZvbG-0004Ns-UZ; Sun, 09 Jun 2019 07:03:02 -0400 Original-Received: by mail-qt1-x834.google.com with SMTP id z24so853067qtj.10; Sun, 09 Jun 2019 04:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZU/7rPbWx4977QxhdruICc6fj71YNj+siFekxsbnc4s=; b=Tr5mcrkRVB7yQxTvew1FtlrLd6bMGMzIcI4dkXbz6SFfRQ/FFHm3IJXAK20b2JE/nq vG0+mxMzCPBEPpLemdt1BFAwbupvgvvKZ0E/q4s9eFC79I42v/anHp+TqVpYpJddMFjw r9x+ZK+6CoqjfcsixtMHB5AfNeq+x3qgZ0IvcHlZnKTE9+wq54uU9SqTOtlnHsT6HX7p wfEIzGMKSkGKN6uyuTfrULyuALQPvYfyJpnFQmmWZ0leE6eyFVqmwJwbKucc5P+eTNvW jCmKQHG35WOt636PKTh4KWWAr6qy4UlyPUPVv5bSSFcFGLgW+XZ6KEYOCs+5Ozt4Z+JY bjhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZU/7rPbWx4977QxhdruICc6fj71YNj+siFekxsbnc4s=; b=IQfVEVjScUYN0fPHcwXE9cJKtBaI8Icm8ZG1rBXLzQ29P90+RE3WZNZ2cv/r2wQndq dsDJ1+bDFtFvHd+8lW2QDVxrLbMiQIAbhVm9/EZ2yd4psFYLe/UApvs5dQlm2n/dTgXb wihnkjX/IFitJNZfQxUwulzCLNofakqoVOxoslaCEoIkgbOwvf03mGLpKz3RaoeImPxk cw6cWwKAYUL9vRqUtPoWnw+0e7xgdebLI8zTbut2iiPAkpb43YG4DHd4KINUEWzRVtVJ 8lE2hUZdhfWMwtjNoZgl00paDuMkBMlxpCMvtZDyF4nBP6bRs9fnA40e39flPYfAa6EC Q6Fw== X-Gm-Message-State: APjAAAXqHwOL0tN05JSO6R26MQLDe7re8cihMhSJ3eVq+MHdPYSPN2TS 7NG1PUf5QKfDZ56kekCMnhOR7P6MQZjD12yAWAOd2F5TVNc= X-Google-Smtp-Source: APXvYqwXRTz+HrRnizYsUvRbncjiQKzpJGZ/2prS+WDwq11lxstt2Iv0J9B2GiFCp0GWxs3o60rzHesG35Ol5kKryGU= X-Received: by 2002:a0c:ad1c:: with SMTP id u28mr52627408qvc.87.1560078175388; Sun, 09 Jun 2019 04:02:55 -0700 (PDT) In-Reply-To: <83wohwo3xw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::834 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237343 Archived-At: On Sat, Jun 8, 2019 at 10:51 AM Eli Zaretskii wrote: > In that > branch, emacs_path comes from the GetModuleFileName call, and we limit > the result from that call to MAX_PATH characters. Correct, and that's why the compiler warning was so explicit: addpm.c:223:36: sprintf (msg, "Install Emacs at %s?\n", emacs_path); ^~ addpm.c:223:4: note: 'sprintf' output between 20 and 279 bytes into a destination of size 260 sprintf (msg, "Install Emacs at %s?\n", emacs_path); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~