From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113747: lisp/frameset.el: Convert `frameset' to vector and add new slots. Date: Thu, 8 Aug 2013 04:12:51 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1375928015 16077 80.91.229.3 (8 Aug 2013 02:13:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Aug 2013 02:13:35 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 08 04:13:38 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V7FjM-00052D-Ov for ged-emacs-devel@m.gmane.org; Thu, 08 Aug 2013 04:13:36 +0200 Original-Received: from localhost ([::1]:57165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7FjL-0003Xr-OW for ged-emacs-devel@m.gmane.org; Wed, 07 Aug 2013 22:13:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7FjI-0003XU-Oe for emacs-devel@gnu.org; Wed, 07 Aug 2013 22:13:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7FjH-0000zU-TF for emacs-devel@gnu.org; Wed, 07 Aug 2013 22:13:32 -0400 Original-Received: from mail-ve0-x22d.google.com ([2607:f8b0:400c:c01::22d]:40098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7FjH-0000zN-Pu for emacs-devel@gnu.org; Wed, 07 Aug 2013 22:13:31 -0400 Original-Received: by mail-ve0-f173.google.com with SMTP id cy12so2587131veb.18 for ; Wed, 07 Aug 2013 19:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=L64rhjhRxGzG8duAnndffGnNykomH+opQhBQM/cuSTQ=; b=CIdQkcWIrC/dy9e0/0Lwt9kQ9/ob5GLemNY4ozthkImYC7uEq3mHKvMEW2wbFDaYrn jP8til8o4rOCXlao0mr+0T+pDZ5Vu6Ba5VKd/19rV+mNLnCVk7DMSH8gzoWR2cZsjEpg lKdMyLxLuR9em1RV1FnWYOsCtSlFMdsQfulvqEXLNYTYA5EmHiRIObUe3cgbOewRqIK9 oQ1cbldkwGNWOCLYJ2BORm8Miu4BbXbukm7h3sVnDPPnA8vEyRW9cLR2osOZS7VcRqXR YTs2o3GQSsmrwJu0j8gyhQzyT7CZYh7uZbCPYtzWttpiA9UXbeXkLCCp35dBk/2Ky2wd q7BA== X-Received: by 10.52.155.1 with SMTP id vs1mr1645230vdb.94.1375928011422; Wed, 07 Aug 2013 19:13:31 -0700 (PDT) Original-Received: by 10.220.245.8 with HTTP; Wed, 7 Aug 2013 19:12:51 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400c:c01::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162479 Archived-At: On Thu, Aug 8, 2013 at 3:56 AM, Stefan Monnier wrote: > I know we have some offenders, but please try to stick to "foo-p returns > a boolean". Why? It's a CL-style predicate, which returns a "generalized boolean" (either nil, or anything else). What is the harm in returning the version? > Also, this doesn't just test whether it's a frameset or not (which is > what one expects from "frameset-p") but it does some sanity checks > as well, something I'd call maybe "frameset-valid-p". It needs to be called `frameset-p' for cl-typep to work. If you're suggesting that I split the current frameset-p into a strict-boolean-returning frameset-p and a more thorough frameset-valid-p, I can do that, but, what is the gain? J