From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] trunk r113747: lisp/frameset.el: Convert `frameset' to vector and add new slots.
Date: Thu, 8 Aug 2013 04:12:51 +0200 [thread overview]
Message-ID: <CAAeL0STZBFfs4_dcFfeMq+zpkbub_FTA0xnsrzx6NLa51jaLMQ@mail.gmail.com> (raw)
In-Reply-To: <jwvwqnxymmv.fsf-monnier+emacs@gnu.org>
On Thu, Aug 8, 2013 at 3:56 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> I know we have some offenders, but please try to stick to "foo-p returns
> a boolean".
Why? It's a CL-style predicate, which returns a "generalized boolean"
(either nil, or anything else). What is the harm in returning the
version?
> Also, this doesn't just test whether it's a frameset or not (which is
> what one expects from "frameset-p") but it does some sanity checks
> as well, something I'd call maybe "frameset-valid-p".
It needs to be called `frameset-p' for cl-typep to work.
If you're suggesting that I split the current frameset-p into a
strict-boolean-returning frameset-p and a more thorough
frameset-valid-p, I can do that, but, what is the gain?
J
next prev parent reply other threads:[~2013-08-08 2:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V7CcV-0008Ec-F2@vcs.savannah.gnu.org>
2013-08-08 1:56 ` [Emacs-diffs] trunk r113747: lisp/frameset.el: Convert `frameset' to vector and add new slots Stefan Monnier
2013-08-08 2:12 ` Juanma Barranquero [this message]
2013-08-08 2:46 ` Stefan Monnier
2013-08-08 3:17 ` Juanma Barranquero
2013-08-08 4:06 ` Drew Adams
2013-08-08 4:09 ` Stefan Monnier
2013-08-08 10:04 ` Juanma Barranquero
2013-08-08 13:03 ` Juanma Barranquero
2013-08-08 13:18 ` Stefan Monnier
2013-08-08 13:43 ` Juanma Barranquero
2013-08-08 14:40 ` Stefan Monnier
2013-08-08 15:34 ` Juanma Barranquero
2013-08-08 16:32 ` Stefan Monnier
2013-08-08 17:00 ` Juanma Barranquero
2013-08-08 17:28 ` Stefan Monnier
2013-08-08 16:50 ` Drew Adams
2013-08-08 16:51 ` Juanma Barranquero
2013-08-08 17:18 ` Drew Adams
2013-08-08 17:32 ` Stefan Monnier
2013-08-08 17:47 ` Juanma Barranquero
2013-08-08 17:51 ` Juanma Barranquero
2013-08-08 16:32 ` Juanma Barranquero
2013-08-08 17:30 ` Stefan Monnier
2013-08-08 17:34 ` Juanma Barranquero
2013-08-08 18:22 ` Stefan Monnier
2013-08-09 0:38 ` Juanma Barranquero
2013-08-08 16:37 ` Drew Adams
2013-08-08 4:05 ` Drew Adams
2013-08-08 15:42 ` Richard Stallman
2013-08-08 15:49 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0STZBFfs4_dcFfeMq+zpkbub_FTA0xnsrzx6NLa51jaLMQ@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.