From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: :extend face attribute at EOB without end-of-line char Date: Mon, 14 Oct 2019 19:52:52 +0200 Message-ID: References: <20191014163219.dieg73u73onqsgyt@Ergus> <20191014170709.mp3uanbg77woxhi3@Ergus> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000091a4aa0594e28b05" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120834"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 14 19:54:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iK4Xy-000VES-MR for ged-emacs-devel@m.gmane.org; Mon, 14 Oct 2019 19:54:18 +0200 Original-Received: from localhost ([::1]:55050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iK4Xx-0006qs-98 for ged-emacs-devel@m.gmane.org; Mon, 14 Oct 2019 13:54:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52259) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iK4XC-0006nH-OY for emacs-devel@gnu.org; Mon, 14 Oct 2019 13:53:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iK4XB-00065Z-Ii for emacs-devel@gnu.org; Mon, 14 Oct 2019 13:53:30 -0400 Original-Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:35090) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iK4XB-00065P-C9 for emacs-devel@gnu.org; Mon, 14 Oct 2019 13:53:29 -0400 Original-Received: by mail-qt1-x833.google.com with SMTP id m15so26637162qtq.2 for ; Mon, 14 Oct 2019 10:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YA1cmvkKHrx0qGaRqE1+GpAu80nuRBrNuXZklPsf17k=; b=a9rp8/4N1CvMcPD87vBrtyhA98gr4uU6Ymp9NNFZ70kUS+PBk9/EY8jYO14M7INLoH tUCzp4LqcZ5LfpGdox2+7VJwVeNkaH7wL3pz+SsB3xm2GP3+sZCvRz25FDwM2/BhnRIE giT1VKtwSx0Wgj+Ciql6GP1KVBKyuZp66lriHA677Ynl4BH4QilIm7xMJSnh/odqO09V qmaYc21jmZd4N/qjadVCXbFJRrHg5QuZ15wkxzSWWLQuaUJftzsyX8vaSkKcPlgKDziz 4ypQyBI56mmEqSm3UPMoJjYN9vO+B/PXzcijavIKntcS2Rq9vgnuS78DiLC/lKZKmwHt qxjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YA1cmvkKHrx0qGaRqE1+GpAu80nuRBrNuXZklPsf17k=; b=iZUdm0JqwbjxaaPxnxAlHIJMGfdfdnRHILk/ouinOKeZO5t4R9HNAKciDBlcgNRaB+ zmeqxX6TBEUXuA+N75cEtKJKhr5HeSZiW72QHcOteTkOsh42wZEsX/5mSaXgW+jUjwxs Wxn04/9VgSzML0gKJXMUDy6CCLtIBWBbKcfGhodhfnXm9rXx1jcXCBwt3McOfetTm8g9 LsbHnC5wpYNDfgZL2/tNZnTp7pMYvqLzCVu3NXkAkAsRx5ROnTPZ+kmaZJ/a6Lpf0Rnx svGuSoGS61VYJZm++ylA4bJuJ9ty3beywQktM9ScD15AQySSh6GUFYe/+OAEppO1zD0p kjOQ== X-Gm-Message-State: APjAAAX5O3T252pHuy3RIBmhtCtq9T6k+w5poH000G5ERRXZI864mFWI uG+uifzamkRytRwlI2suhlfFK070GOrtY4NMFm8= X-Google-Smtp-Source: APXvYqyytcgj5Z+P7BRAbsSxE9J88PqOiySCXVO8fL1wTe7aShLaD0I6kdaY8KwgWn8CwS8zZ/2AeRWeXQlcq1GzvXM= X-Received: by 2002:ac8:435b:: with SMTP id a27mr34326158qtn.242.1571075608649; Mon, 14 Oct 2019 10:53:28 -0700 (PDT) In-Reply-To: <20191014170709.mp3uanbg77woxhi3@Ergus> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::833 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241010 Archived-At: --00000000000091a4aa0594e28b05 Content-Type: text/plain; charset="UTF-8" On Mon, Oct 14, 2019 at 7:07 PM Ergus wrote: > Ok, I am not sure, but I think that actually bs-show is a table, so the > hl-face does not apply. to it because there is a last column (in this > case empty) with the default face. No. The *buffer-selection* buffer is filled with this code in bs-show-in-buffer: (erase-buffer) (setq bs--name-entry-length name-entry-length) (bs--show-header) (dolist (buffer list) (bs--insert-one-entry buffer) (insert "\n")) (delete-char -1) which inserts lines (strings) followed by \n, and then deletes the last \n in the buffer (so the last line does not have a \n at the end, which theoretically simplifies a bit moving around the buffer). The function that creates each line is bs--insert-one-entry, which accumulates the different "fields" into one string, and then just inserts it in the buffer. The effect in the picture in my original post is not showing an empty column in a table. It's an artifact of the last line not having a closing \n. Whether that's intended with face extension or not, I don't know. IMO it would be nicer if the face extended to the end of the line in that case too. --00000000000091a4aa0594e28b05 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Oct 14, 2019 at 7:07 PM Ergus <spacibba@aol.com> wrote:

> Ok, I = am not sure, but I think that actually bs-show is a table, so the
> h= l-face does not apply. to it because there is a last column (in this
>= ; case empty) with the default face.

No. The *buff= er-selection* buffer is filled with this code in bs-show-in-buffer:

=C2=A0 =C2=A0 (erase-buffer)
=C2=A0 =C2=A0 (setq bs--n= ame-entry-length name-entry-length)
=C2=A0 =C2=A0 (bs--show-header)
= =C2=A0 =C2=A0 (dolist (buffer list)
=C2=A0 =C2=A0 =C2=A0 (bs--insert-one= -entry buffer)
=C2=A0 =C2=A0 =C2=A0 (insert "\n"))
=C2=A0 = =C2=A0 (delete-char -1)

which inserts lines (strings) followed by \n= , and then deletes the last \n in the buffer (so the last line does not hav= e a \n at the end, which theoretically simplifies a bit moving around the b= uffer).

The function that creates each line is bs--insert-one-entry,= which accumulates the different "fields" into one string, and th= en just inserts it in the buffer.

The effect in the picture in my or= iginal post is not showing an empty column in a table. It's an artifact= of the last line not having a closing \n. Whether that's intended with= face extension or not, I don't know. IMO it would be nicer if the face= extended to the end of the line in that case too.

--00000000000091a4aa0594e28b05--