all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Ergus <spacibba@aol.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: :extend face attribute at EOB without end-of-line char
Date: Mon, 14 Oct 2019 19:52:52 +0200	[thread overview]
Message-ID: <CAAeL0STOKbaGDAYjH38c80VsojP+c1fXYPuLUCsYUTge8r5=Mw@mail.gmail.com> (raw)
In-Reply-To: <20191014170709.mp3uanbg77woxhi3@Ergus>

[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]

On Mon, Oct 14, 2019 at 7:07 PM Ergus <spacibba@aol.com> wrote:

> Ok, I am not sure, but I think that actually bs-show is a table, so the
> hl-face does not apply. to it because there is a last column (in this
> case empty) with the default face.

No. The *buffer-selection* buffer is filled with this code in
bs-show-in-buffer:

    (erase-buffer)
    (setq bs--name-entry-length name-entry-length)
    (bs--show-header)
    (dolist (buffer list)
      (bs--insert-one-entry buffer)
      (insert "\n"))
    (delete-char -1)

which inserts lines (strings) followed by \n, and then deletes the last \n
in the buffer (so the last line does not have a \n at the end, which
theoretically simplifies a bit moving around the buffer).

The function that creates each line is bs--insert-one-entry, which
accumulates the different "fields" into one string, and then just inserts
it in the buffer.

The effect in the picture in my original post is not showing an empty
column in a table. It's an artifact of the last line not having a closing
\n. Whether that's intended with face extension or not, I don't know. IMO
it would be nicer if the face extended to the end of the line in that case
too.

[-- Attachment #2: Type: text/html, Size: 1434 bytes --]

  reply	other threads:[~2019-10-14 17:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 16:02 :extend face attribute at EOB without end-of-line char Juanma Barranquero
2019-10-14 16:32 ` Ergus
2019-10-14 16:37   ` Juanma Barranquero
2019-10-14 17:07     ` Ergus
2019-10-14 17:52       ` Juanma Barranquero [this message]
2019-10-14 17:57         ` Juanma Barranquero
2019-10-14 17:58     ` Eli Zaretskii
2019-10-14 19:41       ` Juanma Barranquero
2019-10-14 19:47         ` Eli Zaretskii
2019-10-14 19:50           ` Juanma Barranquero
2019-10-14 20:04             ` Eli Zaretskii
2019-10-14 21:37               ` Juanma Barranquero
2019-10-15  6:15                 ` Eli Zaretskii
2019-10-15  8:10                   ` Juanma Barranquero
2019-10-15  8:27                     ` Eli Zaretskii
2019-10-15  8:50                       ` Juanma Barranquero
2019-10-15 13:23                         ` Stefan Monnier
2019-10-15 14:16                           ` Juanma Barranquero
2019-10-15 16:38                       ` Ergus
2019-10-15 16:49                         ` Eli Zaretskii
2019-10-16  0:23                           ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeL0STOKbaGDAYjH38c80VsojP+c1fXYPuLUCsYUTge8r5=Mw@mail.gmail.com' \
    --to=lekktu@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.