all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Ergus <spacibba@aol.com>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring
Date: Thu, 17 Oct 2019 05:59:46 +0200	[thread overview]
Message-ID: <CAAeL0STE94zDiPBof2CNZitWKct6Lm0QxTaUpZ3fSS_U-16aOg@mail.gmail.com> (raw)
In-Reply-To: <874l08m3t4.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

> If that code existed, it would have failed, wouldn't it?  So it seems
> unlikely.

Either that, or the users just did the (and ... t) trick to normalize the
result themselves.

Or it failed, but very rarely. In some cases that I've fixed, the t result
can be produced through many branches of an `or', for example, and most of
them already returned t, but not all.

Or look at speedbar-this-file-in-vc: it had a flaw, because it
promised non-nil but could in some cases return the result of
`run-hook-with-args' (which is documented as having an unspecified return
value). So certainly such bugs can exist and just be triggered in very
unusual situations.

[-- Attachment #2: Type: text/html, Size: 744 bytes --]

  reply	other threads:[~2019-10-17  3:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191017004602.22269.2935@vcs0.savannah.gnu.org>
     [not found] ` <20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
2019-10-17  1:08   ` master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Lars Ingebrigtsen
2019-10-17  1:44     ` Juanma Barranquero
2019-10-17  2:19       ` Lars Ingebrigtsen
2019-10-17  2:26         ` Juanma Barranquero
2019-10-17  2:49           ` Ergus
2019-10-17  3:45             ` Juanma Barranquero
2019-10-17  3:47               ` Lars Ingebrigtsen
2019-10-17  3:59                 ` Juanma Barranquero [this message]
2019-10-17  7:57         ` Eli Zaretskii
     [not found] <<20191017004602.22269.2935@vcs0.savannah.gnu.org>
     [not found] ` <<20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
     [not found]   ` <<875zkonpqm.fsf@gnus.org>
     [not found]     ` <<CAAeL0SSg8_9vELEeH9BtC02Bpf26AVCgLhpsBSAgQ0nLzXtrMw@mail.gmail.com>
     [not found]       ` <<871rvcnmg1.fsf@gnus.org>
     [not found]         ` <<8336frdcs9.fsf@gnu.org>
2019-10-17 15:15           ` Drew Adams
2019-10-17 15:43             ` Juanma Barranquero
2019-10-17 18:02               ` Stefan Monnier
2019-10-17 18:18                 ` Juanma Barranquero
2019-10-17 18:31                   ` Stefan Monnier
2019-10-17 18:37                 ` Eli Zaretskii
2019-10-17 19:29                   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAeL0STE94zDiPBof2CNZitWKct6Lm0QxTaUpZ3fSS_U-16aOg@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.