From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master 49192e9: Strip "(fn...)" from output of `describe-mode' (bug#38222) Date: Tue, 19 Nov 2019 21:25:08 +0100 Message-ID: References: <20191119101930.28082.63466@vcs0.savannah.gnu.org> <20191119101931.EA4E2209BF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000653c430597b8de57" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="166102"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 19 21:26:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXA4s-000h3x-UN for ged-emacs-devel@m.gmane.org; Tue, 19 Nov 2019 21:26:23 +0100 Original-Received: from localhost ([::1]:51356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXA4r-0006ic-CL for ged-emacs-devel@m.gmane.org; Tue, 19 Nov 2019 15:26:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51954) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXA4I-0006iK-Fd for emacs-devel@gnu.org; Tue, 19 Nov 2019 15:25:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXA4H-0001Mo-FT for emacs-devel@gnu.org; Tue, 19 Nov 2019 15:25:46 -0500 Original-Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:46336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXA4H-0001MD-BA for emacs-devel@gnu.org; Tue, 19 Nov 2019 15:25:45 -0500 Original-Received: by mail-qt1-x831.google.com with SMTP id r20so26109667qtp.13 for ; Tue, 19 Nov 2019 12:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UBLe6FVK3SmUlKEQtSvT4Log5p2JFor6PD5K0HmlK9s=; b=TE7bPqEgXkx75ofugB3YJVqS03yvQldxuzPu4hFydlv2I6zeKeXVii5Atuy1I5ppE8 cC4IQNflZPUPdWhIlZalU1L0JZo9vX/d/KuzFBlfOrpkmTNXiV/Xs6fVZqYB8qSwlrQJ THTTDoRh2nHp0XpbfLlfoItxvagY7QMMqWMM7iTpptQgSRFuRZro5JzgUiKw7GZfh0Zm nI8cBC/iL90RmwgFET0mZxSt2dQyYurBEep/OS0e9C07MRH84uQxQbqYi9ySaJwYXbi1 jj5haFVHEFtN6tO0JJdLV5/b0h5BDpoir5m//UH+SPcNIRhAoMLMyaQtJEf9GqnqiI/6 VblA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UBLe6FVK3SmUlKEQtSvT4Log5p2JFor6PD5K0HmlK9s=; b=TwSPCsIzA580C6DBRQ11eQ7/5DtGx86wpV4IPs2pR/rMZt9eWX8LCRwMsgaqkIv5BN w2LUrykq0/NG2R9tPnGthPK50Z3Wtlr+Ho1caeSMVxR3hkCV3zx/AF2A4ocfvlR01MRv YmL2Fod2jZrnc1TGiQSCkJ2x5dkn7iZRuqbyMAGrVW0FC9Du9QVWqywSCIlinwLI1v6J IETVruqeEBoQi+2WsMFqPncLb9QFur6InVd6DCQ2Vb2UeH7Voo4++ZApFU4mP6lDxy8f oeQ0xZit5k9y5JYIU9FynOLJXruLsguVD+nwjSWS6LiYNv8vGNbFFbpa93zT8yQOwLnT 7gRA== X-Gm-Message-State: APjAAAUQt4A263oqPjkjtVCrYJHBlfc7teysaVpQkdyOHurcNHnwEqVr q6inXeyD3bwyHirBq8VBStKbKsZurN+OiuiobxE= X-Google-Smtp-Source: APXvYqzUoEKG2MuXu3cAHjdmby0GF8q8LUK/LaX79GiVNLZDpnmbllkiQDix5dRXY/G3cLM1l1iTp5S5c7Vs7DN7h0A= X-Received: by 2002:ac8:7b9a:: with SMTP id p26mr34725244qtu.287.1574195144504; Tue, 19 Nov 2019 12:25:44 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::831 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242449 Archived-At: --000000000000653c430597b8de57 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 19, 2019 at 9:05 PM Stefan Monnier wrote: > It is because it hides the particular detail about the format we use. As the function I added it's internal and just used from describe-mode, I don't think leaking that detail is something to worry about. In fact, you can un-leak it just by renaming the function to help--docstring-without-usage ;-) > Indeed, to do that we need to see how it's used to see whether it can > safely be changed as-is or whether it needs to depend on some new arg > or something. Of course. Easy to do for our uses of help-split-fundoc, and I'm willing to do it. But we don't know if and how it is used elsewhere. There are a few uses already in ELPA, for example. --000000000000653c430597b8de57 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Nov 19, 2019 at= 9:05 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> It is be= cause it hides the particular detail about the format we use.

As th= e function I added it's internal and just used from describe-mode, I do= n't think leaking that detail is something to worry about. In fact, you= can un-leak it just by renaming the function to help--docstring-without-us= age ;-)

> Indeed, to do that we need to see how it's used to = see whether it can
> safely be chang= ed as-is or whether it needs to depend on some new arg
> or something.

=
Of course. Easy to do for our us= es of help-split-fundoc, and I'm willing to do it. But we don't kno= w if and how it is used elsewhere. There are a few uses already in ELPA, fo= r example.

--000000000000653c430597b8de57--