From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 49192e9: Strip "(fn...)" from output of `describe-mode' (bug#38222)
Date: Tue, 19 Nov 2019 21:25:08 +0100 [thread overview]
Message-ID: <CAAeL0STDxD0seFii-PGOdyFwyN4FytzpjsjfN0x8sJpeTc1CiA@mail.gmail.com> (raw)
In-Reply-To: <jwv1ru37hxp.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Tue, Nov 19, 2019 at 9:05 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> It is because it hides the particular detail about the format we use.
As the function I added it's internal and just used from describe-mode, I
don't think leaking that detail is something to worry about. In fact, you
can un-leak it just by renaming the function to
help--docstring-without-usage ;-)
> Indeed, to do that we need to see how it's used to see whether it can
> safely be changed as-is or whether it needs to depend on some new arg
> or something.
Of course. Easy to do for our uses of help-split-fundoc, and I'm willing to
do it. But we don't know if and how it is used elsewhere. There are a few
uses already in ELPA, for example.
[-- Attachment #2: Type: text/html, Size: 1310 bytes --]
next prev parent reply other threads:[~2019-11-19 20:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191119101930.28082.63466@vcs0.savannah.gnu.org>
[not found] ` <20191119101931.EA4E2209BF@vcs0.savannah.gnu.org>
2019-11-19 13:54 ` master 49192e9: Strip "(fn...)" from output of `describe-mode' (bug#38222) Stefan Monnier
2019-11-19 18:47 ` Juanma Barranquero
2019-11-19 19:22 ` Stefan Monnier
2019-11-19 19:45 ` Juanma Barranquero
2019-11-19 20:05 ` Stefan Monnier
2019-11-19 20:25 ` Juanma Barranquero [this message]
2019-11-19 20:56 ` Stefan Monnier
2019-11-19 21:26 ` Drew Adams
2019-11-22 20:00 ` Juanma Barranquero
2019-11-22 21:45 ` Stefan Monnier
2019-11-23 21:12 ` Juanma Barranquero
2019-11-23 22:08 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0STDxD0seFii-PGOdyFwyN4FytzpjsjfN0x8sJpeTc1CiA@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.