From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 4/4] Fix emacsclient to work with cygw32 Date: Thu, 29 Dec 2011 19:53:14 +0100 Message-ID: References: <3a4c4669da1d97d72975e8943d7b8edff22427c1.1325166472.git.dancol@dancol.org> <83mxabuvj2.fsf@gnu.org> <4EFCA9DB.3030002@dancol.org> <83ehvnutpo.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1325184847 25802 80.91.229.12 (29 Dec 2011 18:54:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 18:54:07 +0000 (UTC) Cc: Daniel Colascione , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 19:54:02 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgL74-0004l0-3q for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 19:54:02 +0100 Original-Received: from localhost ([::1]:41926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgL73-000486-Fm for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 13:54:01 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:57191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgL71-000481-2l for emacs-devel@gnu.org; Thu, 29 Dec 2011 13:53:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgL70-0003Z9-1H for emacs-devel@gnu.org; Thu, 29 Dec 2011 13:53:58 -0500 Original-Received: from mail-pz0-f41.google.com ([209.85.210.41]:41010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgL6y-0003Yn-HR; Thu, 29 Dec 2011 13:53:56 -0500 Original-Received: by dakl33 with SMTP id l33so10721050dak.0 for ; Thu, 29 Dec 2011 10:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=t4VcXbkJ5fz37v1mSMl1J76g6gSUwZ9Po3X8zV275xs=; b=NGwYkzZxtg/M/lHolNMZhXcxAvHE4nzfzC+kbVprcHKuSj6EgEp73ld/fe3BKHoZLH 9CsCoIxfpu7ZP7Rl/5SLPnNCE4yw/qvIIKTWbtdtU3QYV54obJFqGPo0cGeS4vLnMerh Xs68CBsxj1S869l38GREHwVVbZWgUpmER29fk= Original-Received: by 10.68.75.132 with SMTP id c4mr64053578pbw.23.1325184835299; Thu, 29 Dec 2011 10:53:55 -0800 (PST) Original-Received: by 10.142.247.28 with HTTP; Thu, 29 Dec 2011 10:53:14 -0800 (PST) In-Reply-To: <83ehvnutpo.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:147013 Archived-At: On Thu, Dec 29, 2011 at 19:18, Eli Zaretskii wrote: > But the ifdef-out must stay in the native w32 build, I think, because > it causes trouble further down the line. =C2=A0Juanma, can you comment, > please? >From a cursory look and a full five-minute test, I'd say that, in a GUI Emacs server it will cause no harm. When the Emacs server instance is running in a console, "emacsclient -d zzz myfile" will affect deletion of the frame after C-x #. I don't think it'd be hard to fix, but you know how *much* I love fiddling with emacsclient's #ifdefs and flags. Couldn't think of a better Christmas gift for myself. Also, offering the user an option which does nothing is ugly. So I'd vote for #ifdef'ing it away as it is now and sparing us some trouble and testing. =C2=A0 =C2=A0 Juanma