From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Tue, 10 Dec 2019 07:32:01 +0100 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> <87y2vksvut.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009806d5059953ad3e" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187954"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 10 07:32:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ieZ4h-000mnJ-0G for ged-emacs-devel@m.gmane.org; Tue, 10 Dec 2019 07:32:47 +0100 Original-Received: from localhost ([::1]:51080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieZ4f-00031A-S8 for ged-emacs-devel@m.gmane.org; Tue, 10 Dec 2019 01:32:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42950) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieZ4Z-000311-Ja for emacs-devel@gnu.org; Tue, 10 Dec 2019 01:32:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieZ4Y-0007uD-FV for emacs-devel@gnu.org; Tue, 10 Dec 2019 01:32:39 -0500 Original-Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:45007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieZ4Y-0007tz-BM for emacs-devel@gnu.org; Tue, 10 Dec 2019 01:32:38 -0500 Original-Received: by mail-qt1-x833.google.com with SMTP id g17so1775250qtp.11 for ; Mon, 09 Dec 2019 22:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TpTAMlptYbF6tYUaT9/GFI0zKVmpN141kHx5LrtjW7g=; b=oVaAiTPfF/1JBpcBji0QJ6II8IBUmYBYaqq3HED3jgfwWHgHZQZT0ymyNr+ZK1edyi EGMSxdoFZw/+QDYaHCJxIZuuZ0ovfuyqDv4qokkh8afoKv8XSMe3ogGN9L6GTzvpsIDu Nt8KUJSkAZWnIyunLkYu2BIbE5AGVQrPPIGOSizyE1vEl3fjcqvYv/kpL6AiU1TTxeJC fD3uXweW+5iIWXa4LTl90b/bAVXbkU5vuHQVO17FPkWoSniv9amBMbw0qFfBOHMMybjn Scbj4tjYAHPnDmhbw7XtUwRhx9BYkRYvD2nAy4SBbXvkUa5wvSKd1LGqwnNluiuXULoq Gp1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TpTAMlptYbF6tYUaT9/GFI0zKVmpN141kHx5LrtjW7g=; b=mZ+9fD2WEsZxNGOZrIVr7NHygHOySrpQ35TPP69rhcED7kaN1S6d2j62Xt2yKvIm64 tyG+XuWaZ3ejlHI6itF+MuGG2Id/gJl2uW2kEud6QKIrib0EZ7e3L0KKmVHRRha4W26h gvJaZTtis9SzXfuyWZ5C++Cp5wnt++Rp36RQwbu1/pOGevYvRHruGTZjCqZ5l/cRl/ZI HWPxwi3Hv5q83FU8d78aoq+j1K4A10AND8P/rDkd901MIGm74I+C2pumqSp7a0EPrvD5 mwaDj1AkhPnVAhMLjjfmAjtzFU+xfCxK+DBYyQ24rtUBgFlLgkiycDKXPURHrFIqsWJf 66gg== X-Gm-Message-State: APjAAAU5VvIa/VUhN9o4vTjOWbypQwYtDy8uI7oR8s7nd2pHZGHsY/ub zl554mCDeWiaJKzbVu7if/z+Fo3swfkq8lJ3CUrWZw== X-Google-Smtp-Source: APXvYqzWDHJ3NGNKjjbh4iIOoW6dVDmslPUYJPTCdm9DCabSeRX8QHv1vc+qWJZ0QMCDgDD80Z55lhsT56Kext8x5d8= X-Received: by 2002:aed:3c5b:: with SMTP id u27mr29047110qte.287.1575959557308; Mon, 09 Dec 2019 22:32:37 -0800 (PST) In-Reply-To: <87y2vksvut.fsf@alphapapa.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::833 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243276 Archived-At: --0000000000009806d5059953ad3e Content-Type: text/plain; charset="UTF-8" On Tue, Dec 10, 2019 at 4:28 AM Adam Porter wrote: > There are hundreds of thousands, probably millions, of lines of Elisp in > third-party packages and user configurations in the world. Removing the > return value of `push' would be a breaking change affecting innumerable > users. Just for the record, our sources have approx. 1,345,500 non-empty, non-comment lines of lisp. I found 34 uses of the return value of push (could be a few more that I didn't find, but not many). That's one use every ~40,000 lines of code, or approx 0,0025% of them. If code outside has a similar rating, breaking it wouldn't be really something that should kept us awake. But anyway, the point is moot, as non-documenting it just means that the code is mistaken, and will continue to be so. As Stefan as said, nobody was talking about modifying push's implementation. --0000000000009806d5059953ad3e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Dec 10, 2019 at 4:28 = AM Adam Porter <adam@alphapapa.net= > wrote:

> There are hundreds of thousands, probably milli= ons, of lines of Elisp in
> third-party packages and user configurati= ons in the world.=C2=A0 Removing the
> return value of `push' wou= ld be a breaking change affecting innumerable
> users.

Just fo= r the record, our sources have approx. 1,345,500 non-empty,
non-comment lines of lisp. I found 34 uses of the retu= rn value of push
(could be a few = more that I didn't find, but not many).

That's one use every= ~40,000 lines of code, or approx 0,0025% of them.

If code outside = has a similar rating, breaking it wouldn't be really
<= font face=3D"monospace">something that should kept us awake.

But any= way, the point is moot, as non-documenting it just means that the
code is mistaken, and will continue to be = so. As Stefan as said, nobody
was= talking about modifying push's implementation.

--0000000000009806d5059953ad3e--