bug#14527: 24.3.50; error in window-state-get

bug#14527: 24.3.50; error in window-state-get

[Constantin Kulikov]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

emacs-version is "24.3.50.1" (yesterday's trunk) though this error was
introduced in some earlier version.

emacs -Q --debug-init
M-: (window-state-get)
see the error:
```
Debugger entered--Lisp error: (error "Combination limit is meaningful for
internal windows only")
  window-combination-limit(#<window 0x11106b8 on *scratch*>)
  window--state-get-1(#<window 0x11106b8 on *scratch*> nil)
  window-state-get()
  eval((window-state-get) nil)
  eval-expression((window-state-get) nil)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)
```

[-- Attachment #2: Type: text/html, Size: 700 bytes --]

bug#14527: 24.3.50; error in window-state-get

[martin rudalics]

 > emacs-version is "24.3.50.1" (yesterday's trunk) though this error was
 > introduced in some earlier version.
 >
 > emacs -Q --debug-init
 > M-: (window-state-get)
 > see the error:
 > ```
 > Debugger entered--Lisp error: (error "Combination limit is meaningful for
 > internal windows only")
 >   window-combination-limit(#<window 0x11106b8 on *scratch*>)
 >   window--state-get-1(#<window 0x11106b8 on *scratch*> nil)
 >   window-state-get()
 >   eval((window-state-get) nil)
 >   eval-expression((window-state-get) nil)
 >   call-interactively(eval-expression nil nil)
 >   command-execute(eval-expression)
 > ```

Thanks.  It's due to that change:

2013-03-19  Dmitry Antipov  <dmantipov@yandex.ru>

	* window.c (Fwindow_combination_limit, Fset_window_combination_limit):
	Signal error if window is not internal.  Adjust docstring.

You could try to work around it by using

             (combination-limit
	     . ,(unless (window-live-p window)
		  (window-combination-limit window)))

in `window-state-get' but I have no idea whether this would break any
things.  In any case it might be simpler to revert the change because
the original behavior was not broken IIUC.

martin

bug#14527: 24.3.50; error in window-state-get

[Juanma Barranquero]

I've installed Martin's fix** in revno:113172.  I'm leaving this bug
open until someone decides whether that is, indeed, the right fix or
there's something else to be done.

**The slightly different, but essentially identical change suggested
in http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01050.html

bug#14527: 24.3.50; error in window-state-get

[martin rudalics]

> I've installed Martin's fix** in revno:113172.  I'm leaving this bug
> open until someone decides whether that is, indeed, the right fix or
> there's something else to be done.

How about closing this now?

martin

bug#14527: 24.3.50; error in window-state-get

[Juanma Barranquero]

> How about closing this now?

About time.