all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Remi Vanicat <vanicat@debian.org>, 8942@debbugs.gnu.org
Subject: bug#8942: 23.3; emacsclient doesn't exit when called Emacs function is quited.
Date: Mon, 4 Jul 2011 16:41:58 +0200	[thread overview]
Message-ID: <CAAeL0ST5A=GjD=s_hfiakQWB+J+EHWikN3tjoNmq7sHs_oVTQQ@mail.gmail.com> (raw)
In-Reply-To: <jwvaacudsnh.fsf-monnier+emacs@gnu.org>

On Mon, Jul 4, 2011 at 16:32, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Returning a -error would be fine, yes.

But if server-execute catches quit, the whole with-local-quit is not
necessary anymore, is it?

I mean, this patch (shown with -b) fixes the bug report. But when the
user types Ctrl-G in Emacs, he has less feedback because he doesn't
see the "Quit" message anymore.


    Juanma


=== modified file 'lisp/server.el'
--- lisp/server.el	2011-07-04 01:04:29 +0000
+++ lisp/server.el	2011-07-04 14:37:13 +0000
@@ -1121,7 +1121,6 @@
   ;; inhibit-quit flag, which is good since `commands' (as well as
   ;; find-file-noselect via the major-mode) can run arbitrary code,
   ;; including code that needs to wait.
-  (with-local-quit
     (condition-case err
         (let* ((buffers
                 (when files
@@ -1153,7 +1152,7 @@
                              "When done with a buffer, type
\\[server-edit]")))))
           (when (and frame (null tty-name))
             (server-unselect-display frame)))
-      (error (server-return-error proc err)))))
+    ((quit error) (server-return-error proc err))))

 (defun server-return-error (proc err)
   (ignore-errors





  reply	other threads:[~2011-07-04 14:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27  9:37 bug#8942: 23.3; emacsclient doesn't exit when called Emacs function is quited Remi Vanicat
2011-07-04  9:33 ` Juanma Barranquero
2011-07-04 14:32   ` Stefan Monnier
2011-07-04 14:41     ` Juanma Barranquero [this message]
2011-07-04 17:57       ` Stefan Monnier
2011-07-04 18:06         ` Juanma Barranquero
2011-07-04 18:43           ` Stefan Monnier
2011-07-04 22:40             ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeL0ST5A=GjD=s_hfiakQWB+J+EHWikN3tjoNmq7sHs_oVTQQ@mail.gmail.com' \
    --to=lekktu@gmail.com \
    --cc=8942@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=vanicat@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.