From: Juanma Barranquero <lekktu@gmail.com>
To: Eric Raymond <esr@thyrsus.com>
Cc: Bastien <bzg@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names.
Date: Thu, 9 Jan 2014 16:21:15 +0100 [thread overview]
Message-ID: <CAAeL0ST3hFmz7rbiOLnsvWwo29DRLwVfwohx7HmOs7YE95OkWQ@mail.gmail.com> (raw)
In-Reply-To: <20140109150851.GA7194@thyrsus.com>
On Thu, Jan 9, 2014 at 4:08 PM, Eric S. Raymond <esr@thyrsus.com> wrote:
> That's before putting the function alias in place, right?
No, I aliased emacs-bzr-get-version to emacs-repository-get-version
before evalling that code. The error is because (read
emacs-repository-version) will not be guaranteed to return an
integer.
> That is incorrect. emacs-bzr-get-version will return *exactly the name thing*
> as it did before the change, *under all circumstances*.
Not true.
- Before: => nnnn some-bzr-revid
- Now: => nnnn some-bzr-revid (because of the alias)
- In the future, *without* the alias => nil
- In the future, *with* your alias => some-git-revid
> That's right. The old API was misdesigned; it leaked information that
> it should not.
Misdesigned or not (and it was not: it gave me useful information),
it's what it was, what still would be if you hadn't broken it. You
want to design a better API? By all means, do it. Just leave the old
one as obsolete.
> Since that can be fixed in a compatible way, it should be.
"Fixing it in a compatible way" is what I try to do, and you refuse:
- Introduce your newfangled API
- Leave the old one as obsolete.
You're "breaking it in an incompatible way", which is quite different.
J
next prev parent reply other threads:[~2014-01-09 15:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1W124t-0007MM-P3@vcs.savannah.gnu.org>
2014-01-08 23:18 ` trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names Glenn Morris
2014-01-08 23:34 ` Eric S. Raymond
2014-01-08 23:57 ` Juanma Barranquero
2014-01-09 0:04 ` Eric S. Raymond
2014-01-09 0:06 ` Daniel Colascione
2014-01-09 0:12 ` Eric S. Raymond
2014-01-09 0:13 ` Daniel Colascione
2014-01-09 0:09 ` Bastien
2014-01-09 0:27 ` Eric S. Raymond
2014-01-09 0:43 ` Juanma Barranquero
2014-01-09 1:25 ` Eric S. Raymond
2014-01-09 1:31 ` Juanma Barranquero
2014-01-09 2:13 ` Juanma Barranquero
2014-01-09 5:27 ` Eric S. Raymond
2014-01-09 9:36 ` Juanma Barranquero
2014-01-09 12:37 ` Eric S. Raymond
2014-01-09 12:48 ` Juanma Barranquero
2014-01-09 13:13 ` Eric S. Raymond
2014-01-09 13:27 ` Juanma Barranquero
2014-01-09 13:47 ` Eric S. Raymond
2014-01-09 14:05 ` Juanma Barranquero
2014-01-09 14:29 ` Eric S. Raymond
2014-01-09 14:45 ` Juanma Barranquero
2014-01-09 15:08 ` Eric S. Raymond
2014-01-09 15:21 ` Juanma Barranquero [this message]
2014-01-09 20:43 ` chad
2014-01-09 12:00 ` Rüdiger Sonderfeld
2014-01-09 12:12 ` Juanma Barranquero
2014-01-09 12:20 ` Rüdiger Sonderfeld
2014-01-09 12:24 ` Juanma Barranquero
2014-01-09 0:10 ` Juanma Barranquero
2014-01-09 3:48 ` Stephen J. Turnbull
2014-01-09 0:34 ` Glenn Morris
2014-01-09 6:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0ST3hFmz7rbiOLnsvWwo29DRLwVfwohx7HmOs7YE95OkWQ@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.