From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names. Date: Thu, 9 Jan 2014 15:05:43 +0100 Message-ID: References: <20140109012554.GA23333@thyrsus.com> <20140109052705.GA3424@thyrsus.com> <20140109123702.GB5361@thyrsus.com> <20140109131337.GA6053@thyrsus.com> <20140109134716.GA6290@thyrsus.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1389276389 19055 80.91.229.3 (9 Jan 2014 14:06:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jan 2014 14:06:29 +0000 (UTC) Cc: Bastien , Emacs developers To: Eric Raymond Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 09 15:06:33 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W1GFk-0002Dq-1h for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 15:06:32 +0100 Original-Received: from localhost ([::1]:52116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1GFj-000409-K7 for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 09:06:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1GFg-000404-1Y for emacs-devel@gnu.org; Thu, 09 Jan 2014 09:06:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1GFe-0008JP-Sp for emacs-devel@gnu.org; Thu, 09 Jan 2014 09:06:28 -0500 Original-Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:52892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1GFd-0008E8-6h; Thu, 09 Jan 2014 09:06:25 -0500 Original-Received: by mail-ea0-f182.google.com with SMTP id a15so1507919eae.13 for ; Thu, 09 Jan 2014 06:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=j0MHdVf7dafiDEC3wC2O1avxp4mBHH/S243G3qRtq/M=; b=JUjdJ8nYRp3lkZi1Fi/um6gb23Em4pqWuG5L1u1wjxLoqcQvileMiBKbxqiERliwfj Ys3+5tkwZsuvp8isEEoqmIz+H2gtEoZkz/zewk3ah7TvZWz8VUP31ug95vzSsNX7lwpE bHDvUdPDE6lK6QX1HXiYOZekJBYoSH7+AH83l4LCUT9frccZam3l/0/Ip+99jIpYU/yz 53DGdF7rspM8haEyVH/UnnREbml3tEWKMb67d2LJHq6+NdqFZCZeMHoxrFtziLuBxkeK gcgFKd4nEfND/wilCQixuqPC9To9/Qgr9ujkYWt0U/012Qp3HEBacfx2IqaS2t6C5W8W zxBg== X-Received: by 10.15.91.3 with SMTP id r3mr3632687eez.18.1389276384274; Thu, 09 Jan 2014 06:06:24 -0800 (PST) Original-Received: by 10.14.209.69 with HTTP; Thu, 9 Jan 2014 06:05:43 -0800 (PST) In-Reply-To: <20140109134716.GA6290@thyrsus.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167908 Archived-At: On Thu, Jan 9, 2014 at 2:47 PM, Eric S. Raymond wrote: > The more you talk about this, the less you're making any sense to me. Same here. > All this about the return value having structure is a red herring. You > still *get* that structure by looking at emacs-bzr-version. I have > not changed that and will not; only the VCS transition will do that. Yes. And after the transition, code that depends on emacs-release-version and emacs-release-get-version will get a string with a different structure. With your current aliases, they will continue existing, and they will return something different. That is an incompatible change. > With both the variable and function alias in place, I don't understand > what code would need to be changed. (and (bound-and-true-p emacs-bzr-version) (- (read (emacs-bzr-get-version)) (read emacs-bzr-version))) This fails right now because you didn't introduce an alias for emacs-bzr-get-version. But, once that is fixed, it will still fail after the switch because emacs-bzr(-get)-version won't return a string containing a revno. So the only compatible fix is to keep these, not as aliases, but as obsolete. J