From: Juanma Barranquero <lekktu@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring
Date: Thu, 17 Oct 2019 03:44:38 +0200 [thread overview]
Message-ID: <CAAeL0SSg8_9vELEeH9BtC02Bpf26AVCgLhpsBSAgQ0nLzXtrMw@mail.gmail.com> (raw)
In-Reply-To: <875zkonpqm.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Thu, Oct 17, 2019 at 3:08 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Aren't these mostly doc string bugs, though? That is, the doc string
> says "t" instead of "non-nil"; it's a common bug.
Depends. When the function is a predicate, t/nil makes more sense
(generally speaking, there are exceptions) that non-nil/nil.
In this and the other patches, I've opted for the fix (either doc fix, or
code fix) that I thought it was more logical, or matched better the
function's intent, or less prone to cause a bug.
[-- Attachment #2: Type: text/html, Size: 670 bytes --]
next prev parent reply other threads:[~2019-10-17 1:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191017004602.22269.2935@vcs0.savannah.gnu.org>
[not found] ` <20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
2019-10-17 1:08 ` master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Lars Ingebrigtsen
2019-10-17 1:44 ` Juanma Barranquero [this message]
2019-10-17 2:19 ` Lars Ingebrigtsen
2019-10-17 2:26 ` Juanma Barranquero
2019-10-17 2:49 ` Ergus
2019-10-17 3:45 ` Juanma Barranquero
2019-10-17 3:47 ` Lars Ingebrigtsen
2019-10-17 3:59 ` Juanma Barranquero
2019-10-17 7:57 ` Eli Zaretskii
[not found] <<20191017004602.22269.2935@vcs0.savannah.gnu.org>
[not found] ` <<20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
[not found] ` <<875zkonpqm.fsf@gnus.org>
[not found] ` <<CAAeL0SSg8_9vELEeH9BtC02Bpf26AVCgLhpsBSAgQ0nLzXtrMw@mail.gmail.com>
[not found] ` <<871rvcnmg1.fsf@gnus.org>
[not found] ` <<8336frdcs9.fsf@gnu.org>
2019-10-17 15:15 ` Drew Adams
2019-10-17 15:43 ` Juanma Barranquero
2019-10-17 18:02 ` Stefan Monnier
2019-10-17 18:18 ` Juanma Barranquero
2019-10-17 18:31 ` Stefan Monnier
2019-10-17 18:37 ` Eli Zaretskii
2019-10-17 19:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0SSg8_9vELEeH9BtC02Bpf26AVCgLhpsBSAgQ0nLzXtrMw@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.