From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#21816: elisp-mode-tests fails on a case-preserving filesystem Date: Tue, 3 Nov 2015 11:06:57 +0100 Message-ID: References: <86mvuv30i1.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113fbfd639ad5c0523a010fa X-Trace: ger.gmane.org 1446545303 21447 80.91.229.3 (3 Nov 2015 10:08:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Nov 2015 10:08:23 +0000 (UTC) Cc: 21816@debbugs.gnu.org To: Stephen Leake Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 11:08:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtYVh-0003Jr-EM for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 11:08:13 +0100 Original-Received: from localhost ([::1]:46790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtYVg-00089i-KG for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 05:08:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtYVa-000874-Bz for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 05:08:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtYVW-0005nN-7v for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 05:08:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtYVW-0005nG-3C for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 05:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtYVV-0007rC-K4 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 05:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2015 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21816-submit@debbugs.gnu.org id=B21816.144654526130172 (code B ref 21816); Tue, 03 Nov 2015 10:08:01 +0000 Original-Received: (at 21816) by debbugs.gnu.org; 3 Nov 2015 10:07:41 +0000 Original-Received: from localhost ([127.0.0.1]:50445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtYVA-0007qa-Mu for submit@debbugs.gnu.org; Tue, 03 Nov 2015 05:07:41 -0500 Original-Received: from mail-lf0-f44.google.com ([209.85.215.44]:35969) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtYV8-0007qR-HS for 21816@debbugs.gnu.org; Tue, 03 Nov 2015 05:07:39 -0500 Original-Received: by lffz202 with SMTP id z202so11801856lff.3 for <21816@debbugs.gnu.org>; Tue, 03 Nov 2015 02:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=X7D7tP4kBXgB47Y+epRtbzwtm7tkmciDRjaD57RZvc8=; b=PN1hP4OYxJnj8zopRrqUgVui2LrC+sgUd0fO66MpkZivm4D3atRtBJP8f/s7X4pnz6 kofWu53//9EbjDAzJheBjrS5SwVXJU8sEVIatYQoae/kBEt1RiG+pvCUjVM8xItAFXEz Xn7yDX+4Puh3Ro3/j5JDqfkUq/9fR5r3C13CExlGhYF1nLjdNVTX+oqvIWqyJdO50GBW DCTZyXGsZchreUinjXjXP0cJ2L+sahoCvuMVcKVcl3q0BZHFMcMiXeC6FfO+uy17t6Cv hycnWdHa7R+Axx2RLxIFvRnfYifiYrVErthtSs0sNBwzCA67aZqcpaOmFfIM3ucwhw2X 38JA== X-Received: by 10.25.20.24 with SMTP id k24mr8299747lfi.117.1446545257506; Tue, 03 Nov 2015 02:07:37 -0800 (PST) Original-Received: by 10.25.217.132 with HTTP; Tue, 3 Nov 2015 02:06:57 -0800 (PST) In-Reply-To: <86mvuv30i1.fsf@stephe-leake.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108344 Archived-At: --001a113fbfd639ad5c0523a010fa Content-Type: text/plain; charset=UTF-8 On Tue, Nov 3, 2015 at 10:17 AM, Stephen Leake < stephen_leake@stephe-leake.org> wrote: > Well, since this is only a problem in a test run by developers (not > general users), we _could_ insist on that, but I agree it would be nice > not to. I think it points to a problem with xrefs in general. IMO xref-location should have a generic compare function (specialized by default on xref-file-location) so two of them can be compared other than by `equal' and get the right result in case-insensitive systems. And xref-item should also have a generic compare function, whose default implementation would use xref-compare-locations (or whatever the name) to compare its location slots. > The canonical solution for case-insensitive string comparisons is to use > `downcase' on both values before using `equal'. This works for me: It works for me too, though I get a whole bunch of warnings running the test: c:/devel/emacs/repo/trunk/test/automated/elisp-mode-tests.el and c:/Devel/emacs/repo/trunk/test/automated/elisp-mode-tests.el are the same file > ;; We add 'downcase' here to deliberately cause a potential problem on > ;; case-insensitive file systems. On such systems, `load-file-name' > ;; may not have the same case as the real file system, since the user > ;; can set `load-path' to have the wrong case. This is handled in > ;; `xref-elisp-test-run'. In case-insensitive (or, as Windows, case-preserving) systems, that's not the "wrong" case, just an alternative ;-) > If no one objects to this, I'll commit it. Please do, thanks. --001a113fbfd639ad5c0523a010fa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


--001a113fbfd639ad5c0523a010fa--