From: Juanma Barranquero <lekktu@gmail.com>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: 21816@debbugs.gnu.org
Subject: bug#21816: elisp-mode-tests fails on a case-preserving filesystem
Date: Tue, 3 Nov 2015 11:06:57 +0100 [thread overview]
Message-ID: <CAAeL0SSTkW4W58+wkvZX0fKg8Dzuzi8K_+ccqz5UbK-0KijZeQ@mail.gmail.com> (raw)
In-Reply-To: <86mvuv30i1.fsf@stephe-leake.org>
[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]
On Tue, Nov 3, 2015 at 10:17 AM, Stephen Leake <
stephen_leake@stephe-leake.org> wrote:
> Well, since this is only a problem in a test run by developers (not
> general users), we _could_ insist on that, but I agree it would be nice
> not to.
I think it points to a problem with xrefs in general. IMO xref-location
should have a generic compare function (specialized by default on
xref-file-location) so two of them can be compared other than by `equal'
and get the right result in case-insensitive systems. And xref-item should
also have a generic compare function, whose default implementation would
use xref-compare-locations (or whatever the name) to compare its location
slots.
> The canonical solution for case-insensitive string comparisons is to use
> `downcase' on both values before using `equal'. This works for me:
It works for me too, though I get a whole bunch of warnings running the
test:
c:/devel/emacs/repo/trunk/test/automated/elisp-mode-tests.el and
c:/Devel/emacs/repo/trunk/test/automated/elisp-mode-tests.el are the same
file
> ;; We add 'downcase' here to deliberately cause a potential problem on
> ;; case-insensitive file systems. On such systems, `load-file-name'
> ;; may not have the same case as the real file system, since the user
> ;; can set `load-path' to have the wrong case. This is handled in
> ;; `xref-elisp-test-run'.
In case-insensitive (or, as Windows, case-preserving) systems, that's not
the "wrong" case, just an alternative ;-)
> If no one objects to this, I'll commit it.
Please do, thanks.
[-- Attachment #2: Type: text/html, Size: 1949 bytes --]
next prev parent reply other threads:[~2015-11-03 10:06 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 16:41 bug#21816: elisp-mode-tests fails on a case-preserving filesystem Juanma Barranquero
2015-11-02 17:57 ` Eli Zaretskii
2015-11-02 18:20 ` Juanma Barranquero
2015-11-03 1:19 ` Juanma Barranquero
2015-11-03 3:42 ` Eli Zaretskii
2015-11-03 9:17 ` Stephen Leake
2015-11-03 10:06 ` Juanma Barranquero [this message]
2015-11-03 14:51 ` Stephen Leake
2015-11-03 14:58 ` Juanma Barranquero
2015-11-03 19:43 ` Stephen Leake
2015-11-03 22:24 ` Stephen Leake
2015-11-04 8:48 ` Juanma Barranquero
2015-11-09 3:38 ` Dmitry Gutov
2019-10-02 0:57 ` Juanma Barranquero
2015-11-03 15:40 ` Eli Zaretskii
2015-11-03 15:45 ` Juanma Barranquero
2015-11-03 15:52 ` Dmitry Gutov
2015-11-03 16:04 ` Juanma Barranquero
2015-11-03 16:18 ` Dmitry Gutov
2015-11-03 16:33 ` Juanma Barranquero
2015-11-03 18:12 ` Dmitry Gutov
2015-11-04 8:40 ` Juanma Barranquero
2015-11-03 16:34 ` Eli Zaretskii
2015-11-03 16:42 ` Juanma Barranquero
2015-11-03 16:53 ` Eli Zaretskii
2015-11-03 18:13 ` Dmitry Gutov
2015-11-03 19:54 ` Random832
2015-11-03 20:03 ` Dmitry Gutov
2015-11-03 20:25 ` Random832
2015-11-03 21:25 ` Dmitry Gutov
2015-11-03 20:51 ` Eli Zaretskii
2015-11-04 8:19 ` Juanma Barranquero
2015-11-03 18:18 ` Dmitry Gutov
2015-11-03 20:56 ` Eli Zaretskii
2015-11-04 8:53 ` Juanma Barranquero
2015-11-03 19:50 ` Random832
2015-11-03 21:02 ` Eli Zaretskii
2015-11-03 21:17 ` Random832
2015-11-03 21:22 ` Eli Zaretskii
2015-11-03 19:54 ` Stephen Leake
2015-11-03 20:05 ` Dmitry Gutov
2015-11-03 21:07 ` Eli Zaretskii
2015-11-03 21:52 ` Stephen Leake
2015-11-03 22:07 ` Stephen Leake
2015-11-03 22:18 ` Dmitry Gutov
2015-11-03 22:20 ` Stephen Leake
2015-11-04 3:46 ` Eli Zaretskii
2015-11-04 8:28 ` Stephen Leake
2015-11-04 5:24 ` Alexis
2015-11-04 6:33 ` Random832
2015-11-04 6:52 ` Alexis
2015-11-04 15:35 ` Eli Zaretskii
2015-11-04 15:38 ` Eli Zaretskii
2015-11-04 9:04 ` Stephen Leake
2015-11-04 10:37 ` Alexis
2015-11-04 16:08 ` Eli Zaretskii
2015-11-04 15:34 ` Eli Zaretskii
2015-11-03 21:05 ` Eli Zaretskii
2015-11-03 21:58 ` Stephen Leake
2015-11-04 3:42 ` Eli Zaretskii
2015-11-04 10:00 ` Stephen Leake
2015-11-04 19:14 ` Stephen Leake
2015-11-03 19:24 ` Stephen Leake
2015-11-03 21:00 ` Eli Zaretskii
2015-11-04 15:29 ` Stephen Leake
2015-11-05 12:26 ` Juanma Barranquero
2015-11-05 13:23 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0SSTkW4W58+wkvZX0fKg8Dzuzi8K_+ccqz5UbK-0KijZeQ@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=21816@debbugs.gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.