From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter. Date: Sat, 10 Aug 2013 21:37:49 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1376163513 28039 80.91.229.3 (10 Aug 2013 19:38:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 10 Aug 2013 19:38:33 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 10 21:38:36 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V8Ezj-0003Y1-KL for ged-emacs-devel@m.gmane.org; Sat, 10 Aug 2013 21:38:35 +0200 Original-Received: from localhost ([::1]:40666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8Ezi-0003uA-V0 for ged-emacs-devel@m.gmane.org; Sat, 10 Aug 2013 15:38:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8Ezf-0003u5-LG for emacs-devel@gnu.org; Sat, 10 Aug 2013 15:38:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8Eze-0006Ap-MX for emacs-devel@gnu.org; Sat, 10 Aug 2013 15:38:31 -0400 Original-Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:40269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8Eze-0006Ac-Ga for emacs-devel@gnu.org; Sat, 10 Aug 2013 15:38:30 -0400 Original-Received: by mail-ee0-f48.google.com with SMTP id l10so2680706eei.21 for ; Sat, 10 Aug 2013 12:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=5xG2thl3nntgxwD0sw/BEflKLv8+iEjmbS8Kj3bEPgE=; b=HwlZbNEtwU8t6hGkQDDkv8pDFI6wQ2mofJWU5A5m28rTa+za4mO0nS4HBS8cDOAFem VpEj3ocJBh14RFyajzAv1dqm4XwuboaFhGZTL858/UtGpainCcWNgqV/QZ2kHMQXYzAp V7eTjy32kt7gcMTkiIEIHqnrPqMEwmvXknKaa1SyHryr8sC/tRoZMv3nS46yOh89Zs4c 44ZWsSNxd/aYLexbZ1jucw23h61Xcg8Fmdz2XqELSprrTWhkcO9yeaKFmgKpiQ0i4Sfy sZISKu8BJXI/sdiCdR3niytftTWvovlToEbEXH1MwnzEV6522xkuRI6FUI7Bc5+iTfxb cLqw== X-Received: by 10.15.76.71 with SMTP id m47mr6025322eey.70.1376163509297; Sat, 10 Aug 2013 12:38:29 -0700 (PDT) Original-Received: by 10.14.133.15 with HTTP; Sat, 10 Aug 2013 12:37:49 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162555 Archived-At: On Sat, Aug 10, 2013 at 8:22 PM, Stefan Monnier wrote: > So the problem is in the definition of gv-define-simple-setter. It is a problem? It seems quite purposeful. Anway, that definition seems more adequate for `gv-define-setter' than `gv-define-simple-setter' IMO. Of course, it's your call. Unrelated to the warning: the old lambda didn't return `time', and `gv-define-simple-setter' wasn't passed the fix-return arg. J