From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter.
Date: Sat, 10 Aug 2013 21:37:49 +0200 [thread overview]
Message-ID: <CAAeL0SS=y0jRR1zfOFKk-bp2cvNsAQJqJzz2GF63aXCm3TsLwA@mail.gmail.com> (raw)
In-Reply-To: <jwv4naxv22q.fsf-monnier+emacs@gnu.org>
On Sat, Aug 10, 2013 at 8:22 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> So the problem is in the definition of gv-define-simple-setter.
It is a problem? It seems quite purposeful.
Anway, that definition seems more adequate for `gv-define-setter' than
`gv-define-simple-setter' IMO. Of course, it's your call.
Unrelated to the warning: the old lambda didn't return `time', and
`gv-define-simple-setter' wasn't passed the fix-return arg.
J
next prev parent reply other threads:[~2013-08-10 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V88KF-0002U2-9F@vcs.savannah.gnu.org>
2013-08-10 13:25 ` [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter Stefan Monnier
2013-08-10 13:26 ` Juanma Barranquero
2013-08-10 18:22 ` Stefan Monnier
2013-08-10 19:37 ` Juanma Barranquero [this message]
2013-08-11 3:36 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeL0SS=y0jRR1zfOFKk-bp2cvNsAQJqJzz2GF63aXCm3TsLwA@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.