all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: tramp-test42-auto-load failure
Date: Sat, 15 Jun 2019 07:43:53 +0200	[thread overview]
Message-ID: <CAAeL0SS1pSxVffhkEmaNXsPD_aMv5xQgPoaQx6NHYm-J3x68kA@mail.gmail.com> (raw)

tramp-test42-auto-load fails on Windows because remote directories are
not being tested, for lack of a suitable default. So
'tramp-test-temporary-file-directory' is set to "NUL", and
(file-remote-p "NUL") = nil.

In fact, the test used to have

   (skip-unless (tramp--test-enabled))

until commit ad99550610542f8333dc964b3bef2b9e6ad7b0f6, where it was removed.

I've sort of "fixed" it by making the test expect a failure when
'tramp--test-enabled' returns nil, because I didn't want to second
guess that commit's author, Michael Albinus.

Yet I think reverting at least part of that change would be a better
fix, because now it is "expected to fail" on Windows, while the truth
is that the test is not failing; it should simply be skipped.



             reply	other threads:[~2019-06-15  5:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-15  5:43 Juanma Barranquero [this message]
2019-06-15 10:28 ` tramp-test42-auto-load failure Michael Albinus
2019-06-15 19:40   ` Michael Albinus
2019-06-15 19:54     ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAeL0SS1pSxVffhkEmaNXsPD_aMv5xQgPoaQx6NHYm-J3x68kA@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.